Feature/hybrid smart graph testsuite #14056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s is mainly used in Enterprise Code
…at the relevant position
…te correct smartgraph schema
…smart-edge-collections
…godb into feature/hybrid-smart-graph-testsuite
…thub.com:arangodb/arangodb into feature/hybrid-smart-graph-testsuite
…godb into feature/hybrid-smart-graph-testsuite
…godb into feature/hybrid-smart-graph-testsuite
…red for SmartGraphs
…esult instead - will lead to more flexibility handling the result
…riant, we need to modify the result to have it correct
…ngodb/arangodb into feature/hybrid-smart-graph-testsuite
…ut needs help of an enterprise component that des not yet exist
…godb into feature/hybrid-smart-graph-testsuite
…se them from different places as long as we do not do it in multithreaded fashion
…ngodb/arangodb into feature/hybrid-smart-graph-testsuite
…godb into feature/hybrid-smart-graph-testsuite
…ngodb/arangodb into feature/hybrid-smart-graph-testsuite
… check for the data
…, it cannot decide this
mchacki
approved these changes
Jun 30, 2021
|
|
||
| if (!ServerState::instance()->isCoordinator()) { | ||
| // Create IndexAccessor for BaseProviderOptions (TODO: Location need to | ||
| // be changed in the future) create BaseProviderOptions | ||
| BaseProviderOptions forwardProviderOptions(opts->tmpVar(), buildUsedIndexes(), | ||
|
|
||
| // TODO FIXME START - only tmp workaround - we'll provide an empty depth based index info (also add an alias for large type) |
There was a problem hiding this comment.
KanbanCard will be improved in follow up PR.
| @@ -415,6 +415,10 @@ void TraverserEngine::smartSearch(VPackSlice, VPackBuilder&) { | |||
| THROW_ARANGO_EXCEPTION(TRI_ERROR_ONLY_ENTERPRISE); | |||
| } | |||
|
|
|||
| void TraverserEngine::smartSearchNew(VPackSlice, VPackBuilder&) { | |||
There was a problem hiding this comment.
This is temporary, after everything is done, we should have SmartSearch, and remove SmartSearchBFS / SmartSearch calls, as we do not need to distinguish this here.
| @@ -56,6 +55,7 @@ class QueryExpressionContext : public ExpressionContext { | |||
| /// may be inaccessible on some platforms | |||
| transaction::Methods& trx() const override final; | |||
| bool killed() const override final; | |||
| QueryContext& query(); | |||
There was a problem hiding this comment.
KanbanCard to remove this call, I think it is unused already.
| _validator(_interior), | ||
| _interior(resourceMonitor), | ||
| _resultPath{_provider} {} | ||
| _validator(_provider, _interior, std::move(validatorOptions)), |
There was a problem hiding this comment.
We need to fix this ordering.
The _interior is filled after it is handed over to _validator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Addding testsuite (ee) and setup prep. for hybrid smart graphs.