Feature/hybrid smart graph api #14037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rid-smart-graph-api
…arangodb into feature/hybrid-smart-graph-api
…rid-smart-graph-api
This reverts commit 6b921d3.
mchacki
requested changes
Apr 21, 2021
Co-authored-by: Michael Hackstein <michael@arangodb.com>
mchacki
requested changes
Apr 22, 2021
arangod/Graph/GraphManager.cpp
Outdated
| } else { | ||
| documentCollectionsToCreate.emplace(vertexColl); | ||
| } | ||
| if (graph->isHybrid() && |
There was a problem hiding this comment.
I think this is now broken.
You merged 3 ifs not 2.
The behavior should be the following:
if vertexCol is in edgeCollectionsToCreate => Do nothing
else if hybrid() and vertexCol is in satelliteCollections => emplace in satelliteToCreate
else emplace in documentsToCreate
There was a problem hiding this comment.
Thanks for spotting, done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Basic API adjustments to be able to create hybrid smart graphs.