8000 ZKD Indexes by maierlars · Pull Request #13650 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

ZKD Indexes #13650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Sep 10, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
c19d549
Bootstrap zkd indexes. Now fill in the details.
Mar 3, 2021
60d6ceb
Added prototype for condition finder.
Mar 4, 2021
63fd0b7
Added helper for Range.
Mar 4, 2021
a43cf14
Fixed double conversion.
Mar 4, 2021
9305dbc
Added wrong but working nextImpl
Mar 5, 2021
14ba135
Extract bounds for iterator.
Mar 5, 2021
3d7d5fc
Fixed extraction logic with reversed operator usage.
Mar 5, 2021
db52b6d
Detect equal operator correctly.
Mar 5, 2021
ede46db
Implemented nextImpl
goedderz Mar 5, 2021
5c78b96
Removed log devel for hot path.
Mar 5, 2021
0b73dcf
Cleanup
goedderz Mar 5, 2021
4fb378c
Added support for partially unbounded queries.
Mar 5, 2021
6948eb6
Do not use index for full collection scans.
Mar 5, 2021
34117f4
Merge branch 'feature/zkd-index' of github.com:arangodb/arangodb into…
Mar 5, 2021
59fd78e
Added tests for ZkdHelper.
Mar 8, 2021
db392e3
Added functional test suite skeleton for zkd index
goedderz Mar 8, 2021
811e660
Merge remote-tracking branch 'origin/devel' into feature/zkd-index
Mar 8, 2021
91f5651
Some fixes to double conversions
goedderz Mar 8, 2021
5be1cd2
Fixed bug in double to byte_string conversion.
Mar 8, 2021
34c4324
Added support for denormalized doubles and infinity.
Mar 9, 2021
e2977ff
Test all interesting double values.
Mar 9, 2021
c9042d2
Disallow Nan.
Mar 9, 2021
dd3b8f2
Added more js tests.
Mar 9, 2021
7b879dc
Added a lot of tests.
Mar 9, 2021
6fcf4d1
Cleaned up test.
Mar 9, 2021
5697c52
[zkd] Strict comparsion (#13673)
Mar 10, 2021
1d3522d
[zkd] Cluster support (#13677)
Mar 11, 2021
94dd02e
Merge remote-tracking branch 'origin/devel' into feature/zkd-index
Mar 11, 2021
3d1ce4b
Added support for nested fields - excluding expansions. (#13681)
Mar 11, 2021
7618470
[zkd] Unique Constraints (#13691)
Mar 12, 2021
1d4928b
[zkd] Forward Compat (#13694)
Mar 15, 2021
8cabd6f
[zkd] Column Family (#13692)
Mar 15, 2021
bbf25b4
Added zkd index docu block. (#13698)
Mar 15, 2021
caa87ae
Fixed bug in RocksDBKeyBounds and using default cost estimation
Mar 16, 2021
6c6a34e
Merge remote-tracking branch 'origin/devel' into feature/zkd-index
Mar 22, 2021
b81f948
[zkd] testInBox speedup (#13798)
Mar 24, 2021
aaddb71
Feature/zkd index speedup getnextzvalue (#13799)
goedderz Mar 25, 2021
10ed61a
Merge remote-tracking branch 'origin/devel' into feature/zkd-index
May 25, 2021
5a1adc3
Merge remote-tracking branch 'origin/devel' into feature/zkd-index
May 26, 2021
584f524
Merge remote-tracking branch 'origin/devel' into feature/zkd-index
Jul 1, 2021
d650d3f
Updated CHANGELOG.
Jul 1, 2021
265ed5c
Merge branch 'devel' of github.com:arangodb/arangodb into feature/zkd…
goedderz Jul 6, 2021
3c73e3d
Merge remote-tracking branch 'origin/devel' into feature/zkd-index
Jul 15, 2021
41ea5e2
Merge remote-tracking branch 'origin/devel' into feature/zkd-index
Aug 5, 2021
fa7d8b0
Fixing iterator.
Aug 6, 2021
5f83c9f
Merge remote-tracking branch 'origin/devel' into feature/zkd-index
Aug 12, 2021
dd48bf9
Added review suggestions.
Aug 20, 2021
a55c4c6
Merge remote-tracking branch 'origin/devel' into feature/zkd-index
Sep 9, 2021
60473c5
Applied suggestions from review.
Sep 9, 2021
a185712
Merge branch 'devel' into feature/zkd-index
mchacki Sep 10, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added prototype for condition finder.
  • Loading branch information
maierlars committed Mar 4, 2021
commit 60d6ceb85e15b450361312c9968c6adb6cbd1f79
4 changes: 4 additions & 0 deletions arangod/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,9 @@ endif()
include(ClusterEngine/CMakeLists.txt)
include(RocksDBEngine/CMakeLists.txt)

add_library(arango_zkd STATIC Zkd/ZkdHelper.cpp)


add_library(arango_graph STATIC
${LIB_ARANGO_GRAPH_SOURCES}
${ADDITIONAL_LIB_ARANGO_GRAPH_SOURCES}
Expand Down Expand Up @@ -880,6 +883,7 @@ add_library(arango_rocksdb STATIC
${ROCKSDB_SOURCES}
${ADDITIONAL_LIB_ARANGO_ROCKSDB_SOURCES}
)
target_link_libraries(arango_rocksdb arango_zkd)

add_dependencies(arango_rocksdb snappy-static)

Expand Down
12 changes: 12 additions & 0 deletions arangod/RocksDBEngine/RocksDBKey.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,18 @@ bool RocksDBKey::containsLocalDocumentId(LocalDocumentId const& documentId) cons
return false;
}

void RocksDBKey::constructZkdIndexValue(uint64_t indexId, zkd::byte_string const& value, LocalDocumentId documentId) {
_type = RocksDBEntryType::ZkdIndexValue;
size_t keyLength = sizeof(uint64_t) + value.size() + sizeof(uint64_t);
_buffer->clear();
_buffer->reserve(keyLength);
uint64ToPersistent(*_buffer, indexId);
auto sv = value.as_string_view();
_buffer->append(sv.data(), sv.size());
uint64ToPersistent(*_buffer, documentId.id());
TRI_ASSERT(_buffer->size() == keyLength);
}

void RocksDBKey::constructDatabase(TRI_voc_tick_t databaseId) {
TRI_ASSERT(databaseId != 0);
_type = RocksDBEntryType::Database;
Expand Down
3 changes: 3 additions & 0 deletions arangod/RocksDBEngine/RocksDBKey.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include "VocBase/Identifiers/DataSourceId.h"
#include "VocBase/Identifiers/LocalDocumentId.h"
#include "VocBase/voc-types.h"
#include "Zkd/ZkdHelper.h"

#include <rocksdb/slice.h>

Expand Down Expand Up @@ -163,6 +164,8 @@ class RocksDBKey {
//////////////////////////////////////////////////////////////////////////////
void constructRevisionTreeValue(uint64_t objectId);

void constructZkdIndexValue(uint64_t objectId, const zkd::byte_string& value, LocalDocumentId documentId);

public:
//////////////////////////////////////////////////////////////////////////////
/// @brief Extracts the type from a key
Expand Down
1 change: 1 addition & 0 deletions arangod/RocksDBEngine/RocksDBKeyBounds.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ rocksdb::ColumnFamilyHandle* RocksDBKeyBounds::columnFamily() const {
return RocksDBColumnFamilyManager::get(RocksDBColumnFamilyManager::Family::FulltextIndex);
case RocksDBEntryType::LegacyGeoIndexValue:
case RocksDBEntryType::GeoIndexValue:
case RocksDBEntryType::ZkdIndexValue:
return RocksDBColumnFamilyManager::get(RocksDBColumnFamilyManager::Family::GeoIndex);
case RocksDBEntryType::Database:
case RocksDBEntryType::Collection:
Expand Down
8 changes: 8 additions & 0 deletions arangod/RocksDBEngine/RocksDBTypes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@ static rocksdb::Slice KeyGeneratorValue(
static RocksDBEntryType revisionTreeValue = RocksDBEntryType::RevisionTreeValue;
static rocksdb::Slice RevisionTreeValue(
reinterpret_cast<std::underlying_type<RocksDBEntryType>::type*>(&revisionTreeValue), 1);

static RocksDBEntryType zkdIndexValu 6D4E e = RocksDBEntryType::ZkdIndexValue;
static rocksdb::Slice ZdkIndexValue(
reinterpret_cast<std::underlying_type<RocksDBEntryType>::type*>(&zkdIndexValue), 1);
} // namespace

char const* arangodb::rocksDBEntryTypeName(arangodb::RocksDBEntryType type) {
Expand Down Expand Up @@ -141,6 +145,8 @@ char const* arangodb::rocksDBEntryTypeName(arangodb::RocksDBEntryType type) {
return "KeyGeneratorValue";
case arangodb::RocksDBEntryType::RevisionTreeValue:
return "RevisionTreeValue";
case arangodb::RocksDBEntryType::ZkdIndexValue:
return "ZkdIndexValue";
}
return "Invalid";
}
Expand Down Expand Up @@ -239,6 +245,8 @@ rocksdb::Slice const& arangodb::rocksDBSlice(RocksDBEntryType const& type) {
return KeyGeneratorValue;
case RocksDBEntryType::RevisionTreeValue:
return RevisionTreeValue;
case RocksDBEntryType::ZkdIndexValue:
return ZdkIndexValue;
}

return Placeholder; // avoids warning - errorslice instead ?!
Expand Down
3 changes: 2 additions & 1 deletion arangod/RocksDBEngine/RocksDBTypes.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ enum class RocksDBEntryType : char {
KeyGeneratorValue = '=',
View = '>',
GeoIndexValue = '?',
RevisionTreeValue = '@'
RevisionTreeValue = '@',
ZkdIndexValue = 'Z'
};

char const* rocksDBEntryTypeName(RocksDBEntryType);
Expand Down
5 changes: 5 additions & 0 deletions arangod/RocksDBEngine/RocksDBValue.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ RocksDBValue RocksDBValue::VPackIndexValue() {
return RocksDBValue(RocksDBEntryType::VPackIndexValue);
}


RocksDBValue RocksDBValue::ZkdIndexValue() {
return RocksDBValue(RocksDBEntryType::ZkdIndexValue);
}

RocksDBValue RocksDBValue::UniqueVPackIndexValue(LocalDocumentId const& docId) {
return RocksDBValue(RocksDBEntryType::UniqueVPackIndexValue, docId, RevisionId::none());
}
Expand Down
1 change: 1 addition & 0 deletions arangod/RocksDBEngine/RocksDBValue.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ class RocksDBValue {
static RocksDBValue PrimaryIndexValue(LocalDocumentId const& docId, RevisionId revision);
static RocksDBValue EdgeIndexValue(arangodb::velocypack::StringRef const& vertexId);
static RocksDBValue VPackIndexValue();
static RocksDBValue ZkdIndexValue();
static RocksDBValue UniqueVPackIndexValue(LocalDocumentId const& docId);
static RocksDBValue View(VPackSlice const& data);
static RocksDBValue ReplicationApplierConfig(VPackSlice const& data);
Expand Down
Loading
0