8000 Feature/strict typing for error codes by goedderz · Pull Request #13484 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content
< 8000 div class="d-flex flex-column flex-md-row flex-items-start flex-md-items-center">

Feature/strict typing for error codes #13484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 82 commits into from
Feb 8, 2021
Merged

Feature/strict typing for error codes #13484

Changes from 1 commit
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
3e30055
Made Result contain only an optional pointer to an error
goedderz Jan 21, 2021
fd78e02
Fixed compile error
goedderz Jan 21, 2021
df2e43c
Avoid no-error allocations
goedderz Jan 21, 2021
d447876
WIP
goedderz Jan 25, 2021
4d8d9b1
WIP
goedderz Jan 25, 2021
ab77f45
Added concatT and joinT to StringUtils
goedderz Jan 25, 2021
331fad5
Fixed tests
goedderz Jan 25, 2021
bfc7901
Merge branch 'feature/string-utils-concat-join' of github.com:arangod…
goedderz Jan 25, 2021
699a5dc
Changed namespace from impl to detail
goedderz Jan 25, 2021
8aa96ae
Assert capacity
goedderz Jan 25, 2021
b0e1b0c
Fixed compile errors
goedderz Jan 25, 2021
83bb4f8
Return a string_view in Result::errorMessage
goedderz Jan 25, 2021
c2435bc
Removed erroneous line
goedderz Jan 25, 2021
6949f89
Merge branch 'feature/refactor-error-message-string-view' of github.c…
goedderz Jan 25, 2021
0fed08d
Fixed some compile errors
goedderz Jan 26, 2021
d91cfb5
Some minor changes
goedderz Jan 26, 2021
6eb6ee1
Merge branch 'feature/refactor-error-message-string-view' of github.c…
goedderz Jan 26, 2021
1956b21
Update lib/Basics/ResultT.h
goedderz Jan 26, 2021
f5de874
Merge branch 'feature/refactor-error-message-string-view' of github.c…
goedderz Jan 26, 2021
84511fb
Fixed Mac compile error
goedderz Jan 26, 2021
eaacdc0
Merge branch 'feature/string-utils-concat-join' of github.com:arangod…
goedderz Jan 26, 2021
d988cf8
Merge branch 'feature/refactor-error-message-string-view' of github.c…
goedderz Jan 26, 2021
6d83aeb
Update lib/Basics/Result.h
goedderz Jan 27, 2021
937877d
Added errorMessage move overloads
goedderz Jan 27, 2021
4d49f20
Added noexcept where mentioned in reviews
goedderz Jan 27, 2021
0e098b2
Be consistent.
goedderz Jan 27, 2021
9c209b3
Merge branch 'devel' of github.com:arangodb/arangodb into feature/sma…
goedderz Jan 27, 2021
9e25112
Removed superfluous lines
goedderz Jan 27, 2021
bc3c0ef
Merge branch 'devel' of github.com:arangodb/arangodb into feature/sma…
goedderz Jan 27, 2021
27fb946
Fixed merge conflict
goedderz Jan 27, 2021
0433a27
Minor changes
goedderz Jan 27, 2021
0fa6aa1
Added some assertions
goedderz Jan 28, 2021
76f2312
Pass conflictingDocumentKey separately, no longer in a Result's error…
goedderz Jan 28, 2021
690c2d7
Fixed prior commit
goedderz Jan 28, 2021
01ed70a
Added ErrorCode and changed errorfile generation accordingly
goedderz Jan 28, 2021
e57dd14
Regenerate errorfiles if the script changed as well
goedderz Jan 28, 2021
932818c
Make libarango compile with ErrorCode
goedderz Jan 28, 2021
5566c81
Make arango_v8 compile
goedderz Jan 29, 2021
fa8baa3
Make arango_network compile
goedderz Jan 29, 2021
7c49d47
Make arango_shell compile
goedderz Jan 29, 2021
d381218
Make arango_indexes and arango_cluster_engine compile
goedderz Jan 29, 2021
ff8c330
Made arangosh compile
goedderz Jan 29, 2021
4c95166
Made arango_cluster_methods compile
goedderz Jan 29, 2021
a52fe06
Made arangobench compile
goedderz Jan 29, 2021
b555dc1
Made arangoimport, -backup, -restore, and -dump compile
goedderz Jan 29, 2021
b927c56
Made arango_iresearch compile
goedderz Jan 29, 2021
dfe105a
Made arango_storage_engine_common compile
goedderz Jan 29, 2021
f816181
Fix compile error
goedderz Jan 29, 2021
2fa9254
Made arango_agency compile
goedderz Jan 29, 2021
0fc65b7
Made arango_pregel compile
goedderz Jan 29, 2021
a6e7b67
Fixed assertion
goedderz Jan 29, 2021
61e06c6
Made arango_common_rest_handler compile
goedderz Jan 29, 2021
411fec1
Made arango_rocksdb compile
goedderz Jan 29, 2021
d2e717f
Made arango_storage_engine compile
goedderz Jan 29, 2021
1a8d2d6
Made arango_replication compile
goedderz Jan 29, 2021
c812ab7
Merge branch 'feature/small-result-with-external-error' of github.com…
goedderz Jan 29, 2021
943bf3e
Fix
goedderz Feb 1, 2021
e928f04
Only return conflicting key when it's meaningful, to soothe an assertion
goedderz Feb 1, 2021
23b957d
Made arango_vocbase compile
goedderz Feb 1, 2021
0d78b83
Reformat
goedderz Feb 1, 2021
ef30942
Added a comment
goedderz Feb 1, 2021
a29e7bd
Addressed review comments
goedderz Feb 1, 2021
ea52266
Made arango_graph compile
goedderz Feb 1, 2021
a4980a4
Made arango_aql compile
goedderz Feb 1, 2021
672b488
Made arango_v8server compile
goedderz Feb 3, 2021
359575c
Made arangosh compile
goedderz Feb 3, 2021
aeb1ce9
Made arangoserver compile
goedderz Feb 3, 2021
799d190
Merge commit '0737c305c536043a3cde5916957dd2714836d25f' into tmp
goedderz Feb 3, 2021
2580766
Merge branch 'tmp' into feature/strict-typing-for-error-codes
goedderz Feb 3, 2021
64ffbc6
Merge branch 'devel' of github.com:arangodb/arangodb into feature/str…
goedderz Feb 3, 2021
a90d8fb
Made arangodbtests compile
goedderz Feb 3, 2021
92cec6f
Fixed compile errors in CE and tests
goedderz Feb 3, 2021
bd5265e
reformat
goedderz Feb 4, 2021
33b212e
Update arangod/GeneralServer/RestHandler.cpp
goedderz Feb 5, 2021
9523d4b
Update lib/Basics/tri-zip.cpp
goedderz Feb 5, 2021
eb92d47
Update lib/V8/v8-utils.cpp
goedderz Feb 5, 2021
e428231
Addressed review comments
goedderz Feb 5, 2021
ba6f370
Merge branch 'feature/strict-typing-for-error-codes' of github.com:ar…
goedderz Feb 5, 2021
15d03dc
Update lib/Basics/files.cpp
goedderz Feb 5, 2021
8fc6866
Merge branch 'devel' of github.com:arangodb/arangodb into feature/str…
goedderz Feb 5, 2021
1815cf1
Fixed merge conflict: regenerated errorfiles
goedderz Feb 8, 2021
3ca1a7b
Merge branch 'devel' of github.com:arangodb/arangodb into feature/str…
goedderz Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/V8/v8-utils.cpp 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
  • Loading branch information
@goedderz @jsteemann
goedderz and jsteemann authored Feb 5, 2021
commit eb92d4742adf96835b630762b62de08add30ff3b
4 changes: 0 additions & 4 deletions lib/V8/v8-utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5318,10 +5318,6 @@ v8::Handle<v8::Value> TRI_ExecuteJavaScriptString(v8::Isolate* isolate,
/// @brief creates an error in a javascript object, based on error number only
////////////////////////////////////////////////////////////////////////////////

// void TRI_CreateErrorObject(v8::Isolate* isolate, ErrorCode errorNumber) {
// v8::HandleScope scope(isolate);
// CreateErrorObject(isolate, errorNumber, TRI_errno_string(errorNumber));
// }

////////////////////////////////////////////////////////////////////////////////
/// @brief creates an error in a javascript object, based on arangodb::result
Expand Down
0