8000 Feature/strict typing for error codes by goedderz · Pull Request #13484 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Feature/strict typing for error codes #13484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 82 commits into from
Feb 8, 2021
Merged

Feature/strict typing for error codes #13484

merged 82 commits into from
Feb 8, 2021

Conversation

goedderz
Copy link
Member
@goedderz goedderz commented Feb 4, 2021 •
edited
Loading

Scope & Purpose

This PR introduces a type for our error codes, to avoid confusions with other ints, accidental casts from bool and so on.

It also fixes several mistakes of that kind that were found while writing this PR.

Enterprise companion PR: https://github.com/arangodb/enterprise/pull/643

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required
  • Backports required for: (Please specify versions and link PRs)

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as virtually all tests.
  • This PR adds tests that were used to verify all changes:
    • Added new C++ Unit tests
    • Added new integration tests (e.g. in shell_server / shell_server_aql)
    • Added new resilience tests (only if the feature is impacted by failovers)
  • There are tests in an external testing repository:
  • I ensured this code runs with ASan / TSan or other static verification tools

Link to Jenkins PR run:

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/13843/

goedderz and others added 30 commits January 21, 2021 15:10
@goedderz
Made Result contain only an optional pointer to an error
3e30055
@goedderz
Fixed compile error
fd78e02
@goedderz
Avoid no-error allocations
df2e43c
@goedderz
WIP
d447876
@goedderz
WIP
4d8d9b1
@goedderz
Added concatT and joinT to StringUtils
ab77f45
@goedderz
Fixed tests
331fad5
@goedderz
Merge branch 'feature/string-utils-concat-join' of github.com:arangod…
bfc7901 
…b/arangodb into feature/small-result-with-external-error
@goedderz
Changed namespace from impl to detail
699a5dc
@goedderz
Assert capacity
8aa96ae
@goedderz
Fixed compile errors
b0e1b0c
@goedderz
Return a string_view in Result::errorMessage
83bb4f8
@goedderz
Removed erroneous line
c2435bc
@goedderz
Merge branch 'feature/refactor-error-message-string-view' of github.c…
6949f89 
…om:arangodb/arangodb into feature/small-result-with-external-error
@goedderz
Fixed some compile errors
0fed08d
@goedderz
Some minor changes
d91cfb5
@goedderz
Merge branch 'feature/refactor-error-message-string-view' of github.c…
6eb6ee1 
…om:arangodb/arangodb into feature/small-result-with-external-error
@goedderz
Update lib/Basics/ResultT.h
1956b21
@goedderz
Merge branch 'feature/refactor-error-message-string-view' of github.c…
f5de874 
…om:arangodb/arangodb into feature/small-result-with-external-error
@goedderz
Fixed Mac compile error
84511fb
@goedderz
Merge branch 'feature/string-utils-concat-join' of github.com:arangod…
eaacdc0 
…b/arangodb into feature/refactor-error-message-string-view
@goedderz
Merge branch 'feature/refactor-error-message-string-view' of github.c…
d988cf8 
…om:arangodb/arangodb into feature/small-result-with-external-error
@goedderz @jsteemann
Update lib/Basics/Result.h
6d83aeb 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@goedderz
Added errorMessage move overloads
937877d
@goedderz
Added noexcept where mentioned in reviews
4d49f20
@goedderz
Be consistent.
0e098b2
@goedderz
Merge branch 'devel' of github.com:arangodb/arangodb into feature/sma…
9c209b3 
…ll-result-with-external-error
@goedderz
Removed superfluous lines
9e25112
@goedderz
Merge branch 'devel' of github.com:arangodb/arangodb into feature/sma…
bc3c0ef 
…ll-result-with-external-error
@goedderz
Fixed merge conflict
27fb946
jsteemann
jsteemann reviewed Feb 5, 2021
View reviewed changes
jsteemann
jsteemann reviewed Feb 5, 2021
View reviewed changes
jsteemann
jsteemann reviewed Feb 5, 2021
View reviewed changes
jsteemann
jsteemann reviewed Feb 5, 2021
View reviewed changes
jsteemann
jsteemann reviewed Feb 5, 2021
View reviewed changes
jsteemann
jsteemann reviewed Feb 5, 2021
View reviewed changes
< 8000 div data-view-component="true" class="TimelineItem TimelineItem--condensed">
@goedderz @jsteemann
Update arangod/GeneralServer/RestHandler.cpp
33b212e 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
goedderz
goedderz commented Feb 5, 2021
View reviewed changes
goedderz and others added 4 commits February 5, 2021 09:14
@goedderz @jsteemann
Update lib/Basics/tri-zip.cpp
9523d4b 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@goedderz @jsteemann
Update lib/V8/v8-utils.cpp
eb92d47 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@goedderz
Addressed review comments
e428231
@goedderz
Merge branch 'feature/strict-typing-for-error-codes' of github.com:ar…
ba6f370 
…angodb/arangodb into feature/strict-typing-for-error-codes
@goedderz goedderz mentioned this pull request Feb 5, 2021
Merged
16 tasks
@goedderz goedderz changed the title [WIP] RFC: Feature/strict typing for error codes Feature/strict typing for error codes Feb 5, 2021
@goedderz goedderz marked this pull request as ready for review February 5, 2021 15:12
@goedderz
Copy link
Member Author
goedderz commented Feb 5, 2021

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/13873/

@goedderz
Copy link
Member Author
goedderz commented Feb 8, 2021

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/13893/

@goedderz
Copy link
Member Author
goedderz commented Feb 8, 2021

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/13895/

@goedderz
Copy link
Member Author
goedderz commented Feb 8, 2021

image

< 9E88 /div>
@jsteemann jsteemann merged commit 0e41342 into devel Feb 8, 2021
@jsteemann jsteemann deleted the feature/strict-typing-for-error-codes branch February 8, 2021 16:16
@goedderz goedderz mentioned this pull request Feb 24, 2021
Merged
16 tasks
elfringham pushed a commit to elfringham/arangodb that referenced this pull request Apr 20, 2021
@goedderz @jsteemann @elfringham
Feature/strict typing for error codes (arangodb#13484)
71bf9b4 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@goedderz goedderz mentioned this pull request Aug 26, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteemann jsteemann jsteemann left review comments

Assignees

@goedderz goedderz

Labels
None yet
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
2 participants
@goedderz @jsteemann
0