8000 Feature/error messages as string views by goedderz · Pull Request #13455 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Feature/error messages as string views #13455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 66 commits into from
Feb 11, 2021
Merged

Feature/error messages as string views #13455

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
3e30055
Made Result contain only an optional pointer to an error
goedderz Jan 21, 2021
fd78e02
Fixed compile error
goedderz Jan 21, 2021
df2e43c
Avoid no-error allocations
goedderz Jan 21, 2021
d447876
WIP
goedderz Jan 25, 2021
4d8d9b1
WIP
goedderz Jan 25, 2021
ab77f45
Added concatT and joinT to StringUtils
goedderz Jan 25, 2021
331fad5
Fixed tests
goedderz Jan 25, 2021
bfc7901
Merge branch 'feature/string-utils-concat-join' of github.com:arangod…
goedderz Jan 25, 2021
699a5dc
Changed namespace from impl to detail
goedderz Jan 25, 2021
8aa96ae
Assert capacity
goedderz Jan 25, 2021
b0e1b0c
Fixed compile errors
goedderz Jan 25, 2021
83bb4f8
Return a string_view in Result::errorMessage
goedderz Jan 25, 2021
c2435bc
Removed erroneous line
goedderz Jan 25, 2021
6949f89
Merge branch 'feature/refactor-error-message-string-view' of github.c…
goedderz Jan 25, 2021
0fed08d
Fixed some compile errors
goedderz Jan 26, 2021
d91cfb5
Some minor changes
goedderz Jan 26, 2021
6eb6ee1
Merge branch 'feature/refactor-error-message-string-view' of github.c…
goedderz Jan 26, 2021
1956b21
Update lib/Basics/ResultT.h
goedderz Jan 26, 2021
f5de874
Merge branch 'feature/refactor-error-message-string-view' of github.c…
goedderz Jan 26, 2021
84511fb
Fixed Mac compile error
goedderz Jan 26, 2021
eaacdc0
Merge branch 'feature/string-utils-concat-join' of github.com:arangod…
goedderz Jan 26, 2021
d988cf8
Merge branch 'feature/refactor-error-message-string-view' of github.c…
goedderz Jan 26, 2021
6d83aeb
Update lib/Basics/Result.h
goedderz Jan 27, 2021
937877d
Added errorMessage move overloads
goedderz Jan 27, 2021
4d49f20
Added noexcept where mentioned in reviews
goedderz Jan 27, 2021
0e098b2
Be consistent.
goedderz Jan 27, 2021
9c209b3
Merge branch 'devel' of github.com:arangodb/arangodb into feature/sma…
goedderz Jan 27, 2021
95e21c9
Make TRI_errno_string return a string_view
goedderz Jan 27, 2021
9e25112
Removed superfluous lines
goedderz Jan 27, 2021
2e6b197
Merge branch 'feature/small-result-with-external-error' of github.com…
goedderz Jan 27, 2021
6b15b7e
Fixed compile errors due to previous change
goedderz Jan 27, 2021
bc3c0ef
Merge branch 'devel' of github.com:arangodb/arangodb into feature/sma…
goedderz Jan 27, 2021
27fb946
Fixed merge conflict
goedderz Jan 27, 2021
0433a27
Minor changes
goedderz Jan 27, 2021
0fa6aa1
Added some assertions
goedderz Jan 28, 2021
76f2312
Pass conflictingDocumentKey separately, no longer in a Result's error…
goedderz Jan 28, 2021
99d1190
Merge branch 'feature/small-result-with-external-error' of github.com…
goedderz Jan 28, 2021
690c2d7
Fixed prior commit
goedderz Jan 28, 2021
f816181
Fix compile error
goedderz Jan 29, 2021
68be618
Merge branch 'feature/small-result-with-external-error' of github.com…
goedderz Jan 29, 2021
a6e7b67
Fixed assertion
goedderz Jan 29, 2021
943bf3e
Fix
goedderz Feb 1, 2021
e928f04
Only return conflicting key when it's meaningful, to soothe an assertion
goedderz Feb 1, 2021
0d78b83
Reformat
goedderz Feb 1, 2021
ef30942
Added a comment
goedderz Feb 1, 2021
a29e7bd
Addressed review comments
goedderz Feb 1, 2021
054cd6d
Merge branch 'feature/small-result-with-external-error' of github.com…
goedderz Feb 1, 2021
8d8bd19
Merge commit '0737c305c536043a3cde5916957dd2714836d25f' into feature/…
goedderz Feb 2, 2021
6fe7d1b
Merge branch 'devel' of github.com:arangodb/arangodb into feature/err…
goedderz Feb 2, 2021
3900256
Fix va args call in macro
goedderz Feb 3, 2021
9c4335f
autoformat
goedderz Feb 3, 2021
29239a0
Try not to rely on error messages being null-terminated as much as po…
goedderz Feb 3, 2021
6759548
Removed unused parts in exitcodes
goedderz Feb 3, 2021
5b2e94f
Try to fix conversion error on windows
goedderz Feb 3, 2021
0161341
Reverted two changes, fixed a compile error, fixed an off-by-one
goedderz Feb 4, 2021
61b16ff
Added a comment
goedderz Feb 4, 2021
d83d7b7
Merge branch 'devel' of github.com:arangodb/arangodb into feature/err…
goedderz Feb 8, 2021
b4f9613
Adressed some review comments
goedderz Feb 8, 2021
c8021d0
Passed some more errors as string_views
goedderz Feb 8, 2021
4dfcda5
Merge branch 'devel' of github.com:arangodb/arangodb into feature/err…
goedderz Feb 10, 2021
62f8892
Removed merge conflict marker
goedderz Feb 10, 2021
c768295
Fixed merge conflicts
goedderz Feb 10, 2021
baf963f
Fixed erroneous argument to snprintf
goedderz Feb 10, 2021
7463f85
Merge branch 'devel' of github.com:arangodb/arangodb into feature/err…
goedderz Feb 11, 2021
55dd841
Fixed merge conflict
goedderz Feb 11, 2021
72b9738
Removed voc-errors.cpp
goedderz Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed voc-errors.cpp
  • Loading branch information
@goedderz
goedderz committed Feb 11, 2021
commit 72b973802598e76da987e51e6596afeeb58c36cd
1 change: 0 additions & 1 deletion 84CC CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1245,7 +1245,6 @@ if (USE_MAINTAINER_MODE)

set(ERROR_FILES
lib/Basics/voc-errors.h
lib/Basics/voc-errors.cpp
lib/Basics/error-registry.h
js/common/bootstrap/errors.js
)
Expand Down
Loading
0