8000 Fixed AR-113 and added regression tests by goedderz · Pull Request #13196 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Fixed AR-113 and added regression tests #13196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 15, 2020
Merged

Fixed AR-113 and added regression tests #13196

merged 9 commits into from
Dec 15, 2020

Conversation

goedderz
Copy link
Member
@goedderz goedderz commented Dec 10, 2020 •
edited
Loading

Scope & Purpose

Previously, the geo-index-optimizer rule could move expressions into the index which used variables which aren't available yet at the index node.

  • 💩 Bugfix (requires CHANGELOG entry)
  • 📖 CHANGELOG entry made

Backports:

Related Information

  • GitHub issue / Jira ticket number: Fixes AR-113.

Testing & Verification

  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as aql-optimizer-geoindex.
  • This PR adds tests that were used to verify all changes:
    • Added new integration tests

@goedderz goedderz self-assigned this Dec 10, 2020
@goedderz goedderz added 1 Bug 3 AQL Query language related labels Dec 10, 2020
@goedderz goedderz added this to the devel milestone Dec 10, 2020
@goedderz goedderz added 3 Optimizer AQL query optimizer is involved 3 Geo labels Dec 10, 2020
@goedderz
Copy link
Member Author

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/13147/

dhly-etc
dhly-etc reviewed Dec 10, 2020
View reviewed changes
@goedderz
Copy link
Member Author

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/13195/

@jsteemann
Copy link
Contributor

http://172.16.10.101:8080/job/arangodb-matrix-pr/13212/

@goedderz
Copy link
Member Author

http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/13216/

@goedderz
Copy link
Member Author

image

@jsteemann jsteemann merged commit 72a98fa into devel Dec 15, 2020
@jsteemann jsteemann deleted the bug-fix/fix-geoindex-self-reference branch December 15, 2020 08:32
@Simran-B Simran-B mentioned this pull request Dec 16, 2020
Closed
goedderz added a commit that referenced this pull request Dec 17, 2020
@goedderz @jsteemann
Fixed AR-113 and added regression tests (#13196)
4e2ffa1 
Co-authored-by: jsteemann <jan@arangodb.com>
goedderz added a commit that referenced this pull request Dec 17, 2020
@goedderz
Corrected CHANGELOG entry of #13196
7e6a3a2
This was referenced Dec 17, 2020
Merged
Merged
goedderz added a commit that referenced this pull request Dec 17, 2020
@goedderz @jsteemann
Fixed AR-113 and added regression tests (#13196)
5765512 
Co-authored-by: jsteemann <jan@arangodb.com>
goedderz added a commit that referenced this pull request Dec 17, 2020
@goedderz @jsteemann
Fixed AR-113 and added regression tests (#13196)
264d298 
Co-authored-by: jsteemann <jan@arangodb.com>
This was referenced Dec 17, 2020
Merged
Merged
KVS85 added a commit that referenced this pull request Dec 19, 2020
@goedderz @jsteemann @KVS85
Fixed AR-113 and added regression tests (#13196) (#13240)
f779e91 
Co-authored-by: jsteemann <jan@arangodb.com>

Co-authored-by: jsteemann <jan@arangodb.com>
Co-authored-by: Vadim <vadim@arangodb.com>
KVS85 pushed a commit that referenced this pull request Dec 21, 2020
@goedderz @jsteemann
Fixed AR-113 and added regression tests (#13196) (#13241)
d39bc14 
Co-authored-by: jsteemann <jan@arangodb.com>

Co-authored-by: jsteemann <jan@arangodb.com>
KVS85 added a commit that referenced this pull request Dec 27, 2020
@goedderz @jsteemann @KVS85
[3.6] Fixed AR-113 and added regression tests (#13242)
1a259d6 
* Fixed AR-113 and added regression tests (#13196)

Co-authored-by: jsteemann <jan@arangodb.com>

* Update CHANGELOG

Co-authored-by: jsteemann <jan@arangodb.com>
Co-authored-by: Vadim <vadim@arangodb.com>
jsteemann pushed a commit that referenced this pull request Jan 11, 2021
@goedderz
Corrected CHANGELOG entry of #13196 (#13239)
3a06c1f
elfringham pushed a commit to elfringham/arangodb that referenced this pull request Apr 20, 2021
@goedderz @elfringham
Corrected CHANGELOG entry of arangodb#13196 (arangodb#13239)
202d32d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhly-etc dhly-etc dhly-etc left review comments

@jsteemann jsteemann jsteemann approved these changes

Assignees

@goedderz goedderz

Labels
1 Bug 3 AQL Query language related 3 Geo 3 Optimizer AQL query optimizer is involved
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
3 participants
@goedderz @jsteemann @dhly-etc
0