8000 AqlSubqueryExecutionBlockImplExecuteImplementation use moveValueInto instead of cloneValueInto by markuspf · Pull Request #11213 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

AqlSubqueryExecutionBlockImplExecuteImplementation use moveValueInto instead of cloneValueInto #11213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2020
Merged

AqlSubqueryExecutionBlockImplExecuteImplementation use moveValueInto instead of cloneValueInto #11213

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1cf4ba
Fix memory leak in traversal
Mar 3, 2020
f68ca90
Use move instead of clone for AqlValues
Mar 3, 2020
f270d99
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use move instead of clone for AqlValues
  • Loading branch information
Markus Pfeiffer committed Mar 3, 2020
commit f68ca90b26f112913cedbc3c08a4281f7e08a610
6 changes: 3 additions & 3 deletions arangod/Aql/TraversalExecutor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,18 +185,18 @@ auto TraversalExecutor::doOutput(OutputAqlItemRow& output) -> void {
if (_infos.useVertexOutput()) {
AqlValue vertex = _traverser.lastVertexToAqlValue();
AqlVal 6F73 ueGuard guard{vertex, true};
output.cloneValueInto(_infos.vertexRegister(), _inputRow, vertex);
output.moveValueInto(_infos.vertexRegister(), _inputRow, guard);
}
if (_infos.useEdgeOutput()) {
AqlValue edge = _traverser.lastEdgeToAqlValue();
AqlValueGuard guard{edge, true};
output.cloneValueInto(_infos.edgeRegister(), _inputRow, edge);
output.moveValueInto(_infos.edgeRegister(), _inputRow, guard);
}
if (_infos.usePathOutput()) {
transaction::BuilderLeaser tmp(_traverser.trx());
AqlValue path = _traverser.pathToAqlValue(*tmp.builder());
AqlValueGuard guard{path, true};
output.cloneValueInto(_infos.pathRegister(), _inputRow, path);
output.moveValueInto(_infos.pathRegister(), _inputRow, guard);
}
output.advanceRow();
}
Expand Down
0