8000 Feature/aql subquery execution block impl execute implementation count collect by mchacki · Pull Request #11172 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Feature/aql subquery execution block impl execute implementation count collect #11172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 69 commits into from
Feb 29, 2020
Merged

Feature/aql subquery execution block impl execute implementation count collect #11172

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
8b805d7
Move SubqueryStartExecutor to new interface
Jan 29, 2020
8ef2428
Diddle
Jan 31, 2020
2bda19d
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
Jan 31, 2020
147cd0c
Tests pass for SubqueryStartExecutor
Jan 31, 2020
cd694a1
Delete most of the SubqueryEndExecutor tests
Jan 31, 2020
7c5f90a
Skeleton tests
Feb 3, 2020
8f986f0
Junk
Feb 10, 2020
7332eff
Merge branch 'devel' into feature/AqlSubqueryExecutionBlockImplExecut…
Feb 10, 2020
fddf770
Cleanup and make work
Feb 11, 2020
6ddf0f1
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
Feb 11, 2020
1fe1772
Tweak ExecutorTestHelper to test pipelines
Feb 12, 2020
88ba3cd
SubqueryStart/SubqueryEnd
Feb 19, 2020
04de92e
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
Feb 19, 2020
1ae8cbc
Blafummel.
Feb 19, 2020
5881c54
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
Feb 20, 2020
041bd39
Modifications
Feb 20, 2020
de83c7b
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
Feb 20, 2020
187f38a
Fixup tests
Feb 20, 2020
7e33246
Address some comments
Feb 20, 2020
1b47090
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
Feb 20, 2020
bf0b03d
Fix.
Feb 20, 2020
aeb3541
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
Feb 20, 2020
f2baeba
Fix tests
Feb 20, 2020
c5c20f8
Various fixes.
Feb 21, 2020
fc32f25
Made the branch compile on Mac
mchacki Feb 21, 2020
4bb25ce
Intermediate commit, does not compile, required for merge
mchacki Feb 21, 2020
dde4c58
Fixed one of the SplicedSubqueryTests
mchacki Feb 21, 2020
81443f6
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
mchacki Feb 21, 2020
981b1ea
Seperated ShadowRow handling for SubqueryStart/End executors to get a…
mchacki Feb 21, 2020
a5099ef
Allow to use a fullCallStack in ExecutorTestHelper.
mchacki Feb 22, 2020
25e9c51
Added asserts on SubqueryEnd that is not allowed to be called with Sk…
mchacki Feb 22, 2020
24c8d27
Use AqlTestCase in SubqueryStartExecutorTest. Transformed first test …
mchacki Feb 22, 2020
fde3d31
Let ExecutorTestHelper also test for shadowRows
mchacki Feb 22, 2020
bc2ff3a
Adapted SingleInput=>Data+Shadow test to testing Helepr and make it pass
mchacki Feb 22, 2020
cf63e56
Transformed existing SubqueryStart tests to Helper, fixed a test wher…
mchacki Feb 22, 2020
238b905
Fixed Skip in SubqueryStartExecutor
mchacki Feb 23, 2020
6db38d2
Allow the Pipeline to add Consumer and dependency without fiddling wi…
mchacki Feb 23, 2020
8382a37
Added Skip adn ShadowRowForwarding tests to SubqueryStartExecutor
mchacki Feb 23, 2020
16c53a5
Fixed fullCount of SubqueryStart to be called properly.
mchacki Feb 23, 2020
2645708
Renamed isModificationSubquery -> isModificatioNode again
mchacki Feb 24, 2020
6c93d22
Consume more than one subquery en-block
mchacki Feb 24, 2020
5cb901b
Fixed debugReporting in SplicedSubqueryTest. Disabled the skip in sub…
mchacki Feb 24, 2020
c3b4551
Removed AQL debug log level from testing config
mchacki Feb 24, 2020
fca04a4
First version of Subquery Skip bypassing. Including 1 passing test.
mchacki Feb 24, 2020
da8ac78
Added disabled tests for skip, and proposed to do it later
mchacki Feb 24, 2020
43c7252
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
mchacki Feb 24, 2020
c208d55
Fixed reporting of FILTERED in fullCount of EnumerateCollectionExecutor
mchacki Feb 24, 2020
eb5dc91
Enable calculationExecutor execute interface
mchacki Feb 24, 2020
595d7ee
Fixed compile issues
mchacki Feb 24, 2020
2a132d2
To Velocypack the modification Subquery value
mchacki Feb 24, 2020
c509270
Fixed illegal assert and reactivated failure tests
mchacki Feb 25, 2020
cfbf0d8
Fixed compile issue
mchacki Feb 25, 2020
6a3e41f
Deactivated Calculation again
mchacki Feb 25, 2020
1dacb92
Added a testSuite for countCollectExecutor
mchacki Feb 25, 2020
03b6193
Fixed Subquery Test for CountCollect
mchacki Feb 25, 2020
a7f1e56
Added CountCollectImplementation
mchacki Feb 25, 2020
4d7bc3b
Added Compatibility Mode to AqlCallStack
mchacki Feb 26, 2020
24e68a5
Removed IdExecutor<void> the only feature it has can be moved into ID…
mchacki Feb 26, 2020
1335302
When falling back in BlocksWithClients use compatibility stack
mchacki Feb 26, 2020
5db3328
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
mchacki Feb 26, 2020
76a1797
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
mchacki Feb 26, 2020
f3df055
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
mchacki Feb 27, 2020
6c75a75
Fixed EnumerateCollectionExecutor
mchacki Feb 27, 2020
17f7169
Fixed fullCountBehaviour of EnumerateList. Also removed a unlimited,f…
mchacki Feb 27, 2020
f613876
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
mchacki Feb 28, 2020
53ccaa8
Fixed endless loop while skipAl in OperationCursor
mchacki Feb 28, 2020
d8d19a5
Fixed View Executor, which sends a no-limit no-offset upstream.
mchacki Feb 28, 2020
572ac97
Fixed forwarding in NoResultsExecutor
mchacki Feb 28, 2020
1bb0a29
Merge branch 'feature/AqlSubqueryExecutionBlockImplExecuteImplementat…
mchacki Feb 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix.
  • Loading branch information
Markus Pfeiffer committed Feb 20, 2020
commit bf0b03da41c636b91c5147073b7fc184423f8811
1 change: 1 addition & 0 deletions tests/Aql/ExecutorTestHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include "Aql/AqlCallStack.h"
#include "Aql/ExecutionBlock.h"
#include "Aql/ExecutionBlockImpl.h"
#include "Aql/ExecutionEngine.h"
#include "Aql/ExecutionState.h"
#include "Aql/ExecutionStats.h"
#include "Aql/OutputAqlItemRow.h"
Expand Down
1 change: 1 addition & 0 deletions tests/Aql/HashedCollectExecutorTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,7 @@ TEST_P(HashedCollectExecutorTestAggregate, run) {
AqlCall call{}; // unlimited produce
ExecutionStats stats{}; // No stats here
ExecutorTestHelper<2, 2>(*fakedQuery)
.setExecBlock<HashedCollectExecutor>(std::move(infos))
.setInputValue(MatrixBuilder<2>{RowBuilder<2>{1, 5}, RowBuilder<2>{1, 1},
RowBuilder<2>{2, 2}, RowBuilder<2>{1, 5},
RowBuilder<2>{6, 1}, RowBuilder<2>{2, 2},
Expand Down
0