8000 covering index wins late materialization by iurii-i-popov · Pull Request #10673 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

covering index wins late materialization #10673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 13, 2019
Merged

covering index wins late materialization #10673

merged 9 commits into from
Dec 13, 2019

Conversation

iurii-i-popov
Copy link
Contributor

  1. Removed useless calculations:
    LET Segmentation Fault auf dem Mac #2 = Filtern #5

  2. Check late materialization with subqueries

  3. Do not late materialize if Projections Covered By Index

@iurii-i-popov
Copy link
Contributor Author

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7629/

@iurii-i-popov
Copy link
Contributor Author

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7631/

Dronplane
Dronplane approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor
@Dronplane Dronplane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iurii-i-popov iurii-i-popov added this to the 3.6 milestone Dec 11, 2019
@iurii-i-popov
Copy link
Contributor Author

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7686/

@iurii-i-popov
Copy link
Contributor Author

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/7695/

Dronplane
Dronplane approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor
@Dronplane Dronplane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85
Copy link
Contributor
KVS85 commented Dec 13, 2019

Tests blue.

@KVS85 KVS85 merged commit e5910a6 into 3.6 Dec 13, 2019
@KVS85 KVS85 deleted the bug-fix-3.6/index-late-materialization branch December 13, 2019 09:40
KVS85 pushed a commit that referenced this pull request Dec 18, 2019
@iurii-i-popov @KVS85
covering index wins late materialization (#10673)
7270cc4 
* covering index wins late mater, removed redundant vars, supported subqueries

* improvements

* subquery uses document in not calc nodes

* forgotten files

* microchanges after review

* CMake file order

* invalid -> valid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dronplane Dronplane Dronplane approved these changes

@gnusi gnusi Awaiting requested review from gnusi

@KVS85 KVS85 Awaiting requested review from KVS85

Assignees
No one assigned
Labels
3.6.0 9 Ready to Merge
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@iurii-i-popov @KVS85 @Dronplane
0