don't return any in-progress indexes #10431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhly-etc
approved these changes
Nov 13, 2019
KVS85
approved these changes
Nov 14, 2019
|
Tests blue. |
…ont-use-indexes-in-progress
gnusi
approved these changes
Nov 14, 2019
KVS85
pushed a commit
that referenced
this pull request
Nov 14, 2019
* don't return any in-progress indexes * fix handling of in-progress indexes * add test * address review comment
ObiWahn
added a commit
that referenced
this pull request
Nov 26, 2019
…re-3.5/query-timeout * '3.5' of https://github.com/arangodb/arangodb: Allow the optimizer to use indexes (#10543) Updated arangosync to 0.7.0 (#10532) Bug fix 3.5/little weekend fix (#10527) Bug fix 3.5/issue 10470 (#10497) add tests for inventory (#10464) (#10495) fixed issue #10440: Incorrect sorting with sort criteria partially covered by index (#10443) [3.5] Added precondition to ensure that server is still as seen before. (#10477) improve error message (#10478) allow in-place analyzer creation via link definition (#10466) (#10481) make replication timeouts configurable via startup options (#10473) [3.5] no coordinators left behind (#10420) don't return any in-progress indexes (#10431) fix invalid assertion (#10428) show type of index when non-implemented exception is thrown (#10425) Fix dump tests Improve syncer error message (#10404) DEVSUP-492 (#10379) (#10402)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Don't consider in-progress indexes when determining the set of available indexes to be used for AQL queries. It seems that at least in the cluster such indexes could be shown and considered useful for supporting AQL queries.
Enterprise companion PR: https://github.com/arangodb/enterprise/pull/357
Testing & Verification
This change is already covered by existing tests, such as shell_server_aql.
Also added a new test for this.