Feature/aql subquery splicing with gather #10341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
556574a to
7ef8fd8
Compare
…-subquery-splicing-with-gather
…-subquery-splicing-with-gather
…-subquery-splicing-with-gather
markuspf
suggested changes
Nov 15, 2019
There was a problem hiding this comment.
The executor itself is of course simple enough (I think).
It'd be good if we had short descriptions of the AqlValueMaterializer and UnsortingGatherExecutor, and there seems to be a lot of TODOs thorughout which might better be kept in our backlog?
It is (yet again!) rather unfortunate that, to implement the desired code, you had to do major heart surgery in another bit of the code (in the AqlValues); I think in future this should constitute 2 pull requests if at all doable.
I can't quite see whether the tests cover pulling from more than one dependency
markuspf
approved these changes
Nov 15, 2019
markuspf
approved these changes
Nov 15, 2019
ObiWahn
added a commit
that referenced
this pull request
Nov 19, 2019
…ture/remove-db-properties-route * 'devel' of https://github.com/arangodb/arangodb: Feature/aql subquery splicing with gather (#10341) Add braces (#10460) fixed issue #10440: Incorrect sorting with sort criteria partially covered by index (#10442)
This was referenced Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Implement Gather s.t. it works with spliced subqueries, and enable the
splice-subqueriesoptimizer rule with gather blocks.Detailed changes
splice-subqueriesoptimizer rule to allow Gathersplice-subqueriesoptimizer rule, related to cluster blocksTesting & Verification
This change is already covered by existing tests, like
shell_server_aql.Enterprise part
See https://github.com/arangodb/enterprise/pull/361