8000 upgrade boost to 1.71.0 by ObiWahn · Pull Request #10295 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

upgrade boost to 1.71.0 #10295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

upgrade boost to 1.71.0 #10295

wants to merge 7 commits into from

Conversation

ObiWahn
Copy link
Contributor
@ObiWahn ObiWahn commented Oct 22, 2019

No description provided.

ObiWahn and others added 4 commits October 21, 2019 17:45
* bump boost version

* add missing header

* try to fix _snprintf problem

* Revert "try to fix _snprintf problem"

This reverts commit 80cfef0.

* another go at _snprintf
@ObiWahn ObiWahn changed the title add boost 1.17.0 source code upgrade boost to 1.17.0 Oct 22, 2019
…ture/boost-1.7.1-lib-only

* 'devel' of https://github.com/arangodb/arangodb:
  Bug fix/make result ctor noexcept (#10293)
  micro optimizations for case conversion (#10291)
  fix error message (#10281)
  Add Linux to -Werr (#10294)
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Oct 22, 2019

@ObiWahn ObiWahn requested review from jsteemann and KVS85 October 22, 2019 12:41
@jsteemann
Copy link
Contributor

Ok, so we are going more than 50 versions back?

diff --git a/3rdParty/boost/CMakeLists.txt b/3rdParty/boost/CMakeLists.txt
index 6d5399043f..2f3ec0e667 100644
--- a/3rdParty/boost/CMakeLists.txt
+++ b/3rdParty/boost/CMakeLists.txt
@@ -1,7 +1,7 @@
 project(boost)
 
 #the boost version must also be adjusted in the top-level CMakeLists.txt file
-set(boost_version "1.17.0")
+set(boost_version "1.69.0")
 set(BOOST_VERSION ${boost_version} PARENT_SCOPE)
 set(boost_src "${CMAKE_CURRENT_SOURCE_DIR}/${boost_version}")
 

@jsteemann
Copy link
Contributor

Can you also please fix the directory name from 3rdParty/boost/1.17.0 to the correct version number?
It is kind of obvious that the version number is wrong, so I am wondering why I am supposed to review it in this state 🤔

@ObiWahn
Copy link
Contributor Author
ObiWahn commented Oct 22, 2019

It is kind of obvious that the version number is wrong, so I am wondering why I am supposed to review it in this state thinking

Because 2 people did not notice.

@ObiWahn ObiWahn changed the title upgrade boost to 1.17.0 upgrade boost to 1.71.0 Oct 22, 2019
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Oct 22, 2019

Clean up the version mess in a new PR

@ObiWahn ObiWahn closed this Oct 22, 2019
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Oct 22, 2019

#10299

@ObiWahn ObiWahn deleted the feature/boost-1.7.1-lib-only branch October 22, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0