8000 add the ability to force the traffic from/to the server to be json, for better sniffeability by dothebart · Pull Request #10239 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

add the ability to force the traffic from/to the server to be json, for better sniffeability #10239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 14, 2019
Merged

add the ability to force the traffic from/to the server to be json, for better sniffeability #10239

merged 4 commits into from
Oct 14, 2019

Conversation

dothebart
Copy link
Contributor

This can be observed while sniffing the tests, i.e. like this:

./scripts/unittest shell_client --forceJson true   --test tests/js/client/shell/shell-async-request.js --sniff sudo  --sleepBeforeStart 5

@dothebart
Copy link
Contributor Author

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6713/

jsteemann
jsteemann suggested changes Oct 14, 2019
View reviewed changes
@dothebart
Copy link
Contributor Author

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6729/

Simran-B
Simran-B reviewed Oct 14, 2019
View reviewed changes
@dothebart @Simran-B
Update arangosh/Shell/ClientFeature.cpp
e79c931 
Co-Authored-By: Simran <Simran-B@users.noreply.github.com>
@dothebart
Copy link
Contributor Author

testrun green except for unrelated problems.

@jsteemann jsteemann merged commit 5ebd0d1 into devel Oct 14, 2019
@jsteemann jsteemann deleted the feature/add-force-json-downgrade branch October 14, 2019 14:54
ObiWahn added a commit that referenced this pull request Oct 14, 2019
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
d2b4692 
…ture/cpp17

* 'devel' of https://github.com/arangodb/arangodb:
  Bug fix/eslint proper settings (#10251)
  A mixed bag of goods (#10220)
  add the ability to force the traffic from/to the server to be json, for better sniffeability (#10239)
  disallow subqueries in AQL traversal PRUNE conditions (#10232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simran-B Simran-B Simran-B left review comments

@jsteemann jsteemann jsteemann approved these changes

@ObiWahn ObiWahn Awaiting requested review from ObiWahn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dothebart @jsteemann @Simran-B
0