8000 Bring back telemetry for storage. by basert · Pull Request #9903 · appwrite/appwrite · GitHub
[go: up one dir, main page]
Skip to content

Bring back telemetry for storage. #9903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christyjacob4 merged 2 commits into from
Jun 3, 2025
Merged

Bring back telemetry for storage. #9903

christyjacob4 merged 2 commits into from
Jun 3, 2025

Conversation

@basert
Copy link
Contributor
@basert basert commented May 26, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Introduced telemetry integration for cache and storage devices, enabling enhanced monitoring and observability across all device resources.

  • Chores

    • Updated internal resource dependencies to support telemetry, ensuring consistent instrumentation throughout the application.

@coderabbitai
Copy link
Contributor
coderabbitai bot commented May 26, 2025 •
edited
Loading

Walkthrough

Telemetry integration has been added to cache and storage device resources in both the main application and worker. Resource factory functions now accept a Telemetry adapter parameter and return instances instrumented with telemetry, either by setting the adapter or wrapping the device in a telemetry decorator. Resource dependencies and signatures are updated accordingly.

Changes

File(s) Change Summary
app/init/resources.php Cache and device resource factories updated to accept Telemetry adapter; devices wrapped with telemetry decorator; dependencies and imports updated.
app/worker.php Device resource factories updated to accept Telemetry adapter; devices wrapped with telemetry decorator; dependencies updated.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ResourceFactory
    participant TelemetryAdapter
    participant Device
    participant TelemetryDevice

    Client->>ResourceFactory: Request device resource (with Telemetry)
    ResourceFactory->>Device: Create original Device
    ResourceFactory->>TelemetryAdapter: Access Telemetry adapter
    ResourceFactory->>TelemetryDevice: Wrap Device with TelemetryAdapter
    TelemetryDevice-->>Client: Return Telemetry-instrumented Device
Loading

Poem

In the warren where data flows free,
Telemetry hops in with glee!
Devices now track,
With a hop and a knack,
Every cache, every file—so bunny can see.
🐇✨📦

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4fafb47 and 809d31b.

📒 Files selected for processing (1)
  • app/worker.php (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/worker.php
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: scan
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@basert basert force-pushed the storage-telemetry branch from 1c8c79d to 4fafb47 Compare May 26, 2025 15:43
@github-actions
Copy link
github-actions bot commented May 26, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
github-actions bot commented May 26, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 816
  • Requests with 200 status code: 146,987
  • P99 latency: 0.231566537

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 816 1,017
200 146,987 183,123
P99 0.231566537 0.18467038

@basert basert changed the base branch from main to 1.7.x June 3, 2025 08:05
@christyjacob4 christyjacob4 merged commit 41cda12 into 1.7.x Jun 3, 2025
38 checks passed
@christyjacob4 christyjacob4 deleted the storage-telemetry branch June 3, 2025 08:37
@coderabbitai coderabbitai bot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@basert @christyjacob4
0