8000 feat(dispatch): add contextual dispatch logic by basert · Pull Request #9687 · appwrite/appwrite · GitHub
[go: up one dir, main page]
Skip to content

feat(dispatch): add contextual dispatch logic#9687

Merged
christyjacob4 merged 1 commit into1.6.xfrom
PLA-2807
Apr 25, 2025
Merged

feat(dispatch): add contextual dispatch logic#9687
christyjacob4 merged 1 commit into1.6.xfrom
PLA-2807

Conversation

@basert
Copy link
Contributor
@basert basert commented Apr 24, 2025 •
edited
Loading

Swoole dispatch_func gets called multiple times during a request lifecycle:

  • on connection establish, with the initial HTTP request data (up to first 8k bytes of request)
  • on connection close, without request data

The underlying TCP connection is shared between all Swoole processes and it's not guaranteed that the dispatch_func is called on the same process all the time.
The previous implementation returned a random workerId when there was no data as part of the request. This happens during connection close phase. Debugging the trace here showed the dispatch_func getting invoked over and over again. This caused really high CPU load.

It seems Swoole expects the same workerId during connection close that was initially assigned during the connection establish phase. This means we need to bind the assigned workerId to the current $fd and use DISPATCH_UIDMOD.

@coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 24, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I p 8000 ushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
github-actions bot commented Apr 24, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
github-actions bot commented Apr 24, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,152
  • Requests with 200 status code: 207,396
  • P99 latency: 0.157694291

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,152 1,404
200 207,396 252,766
P99 0.157694291 0.130181516

@basert basert force-pushed the PLA-2807 branch 3 times, most recently from b0892b1 to 70273eb Compare April 24, 2025 15:34
TorstenDittmann
TorstenDittmann reviewed Apr 24, 2025
View reviewed changes
@christyjacob4 christyjacob4 merged commit 09ca143 into 1.6.x Apr 25, 2025
31 checks passed
@christyjacob4 christyjacob4 deleted the PLA-2807 branch April 25, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann left review comments

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@Meldiron Meldiron Awaiting requested review from Meldiron

@stnguyen90 stnguyen90 Awaiting requested review from stnguyen90

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@basert @TorstenDittmann @christyjacob4
0