Documentsdb + vectordb (latest)#11402
Open
ArnabChatterjee20k wants to merge 300 commits into1.8.xfrom
Open
Conversation
* setAttributeS 10BC0 upport to support context schema and schemaless in mongodb * updated the connection registers
* database dsn fetching * removed dsn from response models
* pools , env setup * collections, db endpoints
…mongo transactions
* updated tests
abnegate
reviewed
Mar 10, 2026
Comment on lines
+64
to
73
| [ | ||
| '$id' => ID::custom('database'), | ||
| 'type' => Database::VAR_STRING, | ||
| 'size' => 128, | ||
| 'required' => true, | ||
| 'signed' => true, | ||
| 'array' => false, | ||
| 'filters' => [], | ||
| ] | ||
| ], |
abnegate
reviewed
Mar 10, 2026
docker-compose.yml
Outdated
| args: | ||
| MODELS: ${_APP_EMBEDDING_MODELS:-embeddinggemma} | ||
| # duration to keep model in memory | ||
| OLLAMA_KEEP_ALIVE: 24h |
Member
There was a problem hiding this comment.
Let's make this forever if possible, no need to re-download unless the model itself needs updating
* Added new exception `MIGRATION_DATABASE_TYPE_UNSUPPORTED` with proper error metadata and HTTP 400 response. * Replaced generic CSV database type errors with the new migration-specific exception for clearer error handling. * Added support for `DOCUMENTSDB` in migration transfer resource service mapping. * Fixed Appwrite report initialization by correctly injecting `getDatabasesDB`. * Updated database adapter initialization to conditionally disable attribute support for `DOCUMENTSDB`. * Moved `setSupportForAttributes` logic from pool initialization to database resource creation. * Removed duplicate `getDatabasesDB` resource definition and redundant database event listener setup. * Cleaned up unused variables and minor code inconsistencies. * Fixed docblock formatting in `TransactionState`. * Adjusted metrics handling in VectorDB embeddings text creation (removed unnecessary trigger/reset flow).
- Introduced a new constant `LEGACY` in Constants.php. - Updated `databaseType` in Action classes to use `LEGACY` instead of `TABLESDB`. - Cleaned up duplicate parameter definition in Create.php for transactionId.
* reverted install php * deleted databasebase from tablesdb
- Updated embedding agent timeout to be configurable via environment variable. - Removed commented code in XList for clarity. - Refactored database cleaning logic into separate methods for better readability and maintainability.
- Changed version constraint for `spomky-labs/otphp` in composer.json to allow any 11.x version. - Refactored `getDatabasesDBForProject` method in Migrations class to use the shorthand syntax for callable. - Updated return values in Format class to use more descriptive types for index creation. - Corrected parameter documentation in Attributes class for clarity and consistency.
- Updated docker-compose.yml to use a pre-built PostgreSQL image instead of a custom build. - Removed obsolete PostgreSQL Dockerfiles from the project. - Updated composer.lock with a new content hash.
- Moved the `setSupportForAttributes` method call from the adapter initialization to the database resource creation in `getDatabasesDB`. - Updated the logic to ensure attribute support is set correctly based on the database type.
…th eventual assertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
Currently this pr is pointing to 1.8.x but will be merged in documentsdb branch as this branch is extracted from documentsdb branch only and contains all the changes needed for the documentsdb syncing with 1.8.x branch
But currently it is poininting to 1.8.x to see the changes needed easily
Related PRs and Issues
Checklist