8000 Update composer.lock and enhance error logging in HTTP requests by eldadfux · Pull Request #11384 · appwrite/appwrite · GitHub
[go: up one dir, main page]

Skip to content

Update composer.lock and enhance error logging in HTTP requests#1 8000 1384

Merged
eldadfux merged 4 commits into1.8.xfrom
fix-proper-error-namespace-and-method
Feb 24, 2026
Merged

Update composer.lock and enhance error logging in HTTP requests#11384
eldadfux merged 4 commits into1.8.xfrom
fix-proper-error-namespace-and-method

Conversation

@eldadfux
Copy link
Member

Fix for Sentry error reporting when error happens before we have the route object.

- Updated versions for several dependencies in composer.lock, including utopia-php/database (5.3.3), utopia-php/detector (0.2.4), utopia-php/dns (1.6.5), utopia-php/framework (0.33.40), utopia-php/queue (0.15.6), and utopia-php/storage (1.0.1).
- Improved error logging in app/http.php and app/controllers/general.php to handle null routes gracefully, ensuring that the HTTP method and request URI are logged correctly even when the route is not defined.
@coderabbitai
Copy link
Contributor
coderabbitai bot commented Feb 23, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b1b7bd and 2b53077.

📒 Files selected for processing (1)
  • app/http.php

📝 Walkthrough

Walkthrough

The changes add defensive null-safe handling for route object access in error-logging paths across two files. Method, path, and SDK label retrieval now use null-safe calls and fall back to values from the request when the route is absent. Action resolution gains a concrete fallback format (http.{METHOD}.{path}) derived from the request URI when no route is available, ensuring a valid action label in error logs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title mentions updating composer.lock and enhancing error logging, but the actual changeset focuses primarily on fixing error logging for null route objects. The composer.lock update is secondary.
Description check ✅ Passed The description directly addresses the core change: fixing Sentry error reporting when errors occur before the route object is available, which aligns with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-proper-error-namespace-and-method

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
github-actions bot commented Feb 23, 2026

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libecpg 18.1-r0 CVE-2026-2004 HIGH
libecpg 18.1-r0 CVE-2026-2005 HIGH
libecpg 18.1-r0 CVE-2026-2006 HIGH
libecpg 18.1-r0 CVE-2026-2007 HIGH
libecpg-dev 18.1-r0 CVE-2026-2004 HIGH
libecpg-dev 18.1-r0 CVE-2026-2005 HIGH
libecpg-dev 18.1-r0 CVE-2026-2006 HIGH
libecpg-dev 18.1-r0 CVE-2026-2007 HIGH
libpq 18.1-r0 CVE-2026-2004 HIGH
libpq 18.1-r0 CVE-2026-2005 HIGH
libpq 18.1-r0 CVE-2026-2006 HIGH
libpq 18.1-r0 CVE-2026-2007 HIGH
libpq-dev 18.1-r0 CVE-2026-2004 HIGH
libpq-dev 18.1-r0 CVE-2026-2005 HIGH
libpq-dev 18.1-r0 CVE-2026-2006 HIGH
libpq-dev 18.1-r0 CVE-2026-2007 HIGH
postgresql18-dev 18.1-r0 CVE-2026-2004 HIGH
postgresql18-dev 18.1-r0 CVE-2026-2005 HIGH
postgresql18-dev 18.1-r0 CVE-2026-2006 HIGH
postgresql18-dev 18.1-r0 CVE-2026-2007 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	composer.lock
@github-actions
Copy link
github-actions bot commented Feb 23, 2026

✨ Benchmark results

  • Requests per second: 1,909
  • Requests with 200 status code: 343,648
  • P99 latency: 0.083937134

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,909 1,144
200 343,648 205,917
P99 0.083937134 0.180209048

Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	composer.lock
@eldadfux eldadfux merged commit f832b96 into 1.8.x Feb 24, 2026
8 checks passed
@github-actions
Copy link
github-actions bot commented Feb 24, 2026

🔄 PHP-Retry Summary

Flaky tests detected across commits:

Commit 2b53077 - 11 flaky tests
Test Retries Total Time Details
UsageTest::testDatabaseStatsCollectionsAPI 1 10.21s Logs
LegacyCustomClientTest::testInvalidDocumentStructure 1 241.58s Logs
TablesDBCustomClientTest::testNotStartsWith 1 240.56s Logs
TablesDBCustomServerTest::testUpdateAttributeEnum 1 240.33s Logs
TablesDBCustomServerTest::testUniqueIndexDuplicate 1 351ms Logs
DatabasesStringTypesTest::testCreateTable 1 246.82s Logs
DatabasesStringTypesTest::testCreateVarcharColumn 1 243.88s Logs
LegacyT 87CB ransactionsConsoleClientTest::testTransactionSizeLimit 1 240.39s Logs
LegacyTransactionsCustomClientTest::testUpsertDocument 1 241.04s Logs
TablesDBTransactionsConsoleClientTest::testBulkDeleteOperations 1 240.87s Logs
TablesDBTransactionsCustomServerTest::testCreateDocument 1 241.05s Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0