8000 Feat fix for missing null safety on console redirects by eldadfux · Pull Request #11380 · appwrite/appwrite · GitHub
[go: up one dir, main page]
Skip to content

Feat fix for missing null safety on console redirects#11380

Merged
eldadfux merged 1 commit into1.8.xfrom
feat-fix-email-key
Feb 24, 2026
Merged

Feat fix for missing null safety on console redirects#11380
eldadfux merged 1 commit into1.8.xfrom
feat-fix-email-key

Conversation

@eldadfux
Copy link
Member
@eldadfux eldadfux commented Feb 22, 2026

This was throwing an error on the container logs:

Warning: Undefined array key "path" in /usr/src/code/vendor/appwrite/server-ce/src/Appwrite/Platform/Modules/Console/Http/Redirects/Base.php on line 40

@eldadfux eldadfux changed the base branch from main to 1.8.x February 22, 2026 19:40
@coderabbitai
Copy link
Contributor
coderabbitai bot commented Feb 22, 2026 •
edited 8000
Loading

Caution

Review failed

Failed to post review comments

📝 Walkthrough

Walkthrough

This pull request performs a major architectural refactoring and feature expansion of the Appwrite codebase. The changes migrate the HTTP routing layer from the legacy App facade to a new Http facade across controllers and core infrastructure, restructure resource identifiers from project-centric naming to generic resource-based patterns (resourceType/resourceInternalId), introduce new API key types (organization and account scopes), expand database schemas with new attributes for deployments and sites, add centralized CORS configuration, introduce new event types and constants, migrate numerous shell scripts to use exec with proper argument quoting, update GitHub Actions workflows, and remove or refactor several API endpoint files into module-based handlers. Supporting changes include new scope configurations for organizations and accounts, expanded configuration for SDKs and function templates, and new initialization files for span tracing and models.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

  • #11239 — Performs the same large-scale App→Http routing migration with related dependency and resource signature updates across controllers and core files.
  • #11040 — Updates shell wrapper scripts in bin/* with the same exec and proper argument quoting pattern changes for process replacement.
  • #9649 — Modifies configuration and initialization files (environment variables, resource handling, routing) with overlapping changes to domain, compute, and resource-token patterns.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main change: fixing missing null safety on console redirects, which is clearly present in the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the specific warning error that prompted the changes to address null-safety issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-fix-email-key

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
github-actions bot commented Feb 22, 2026

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libecpg 18.1-r0 CVE-2026-2004 HIGH
libecpg 18.1-r0 CVE-2026-2005 HIGH
libecpg 18.1-r0 CVE-2026-2006 HIGH
libecpg 18.1-r0 CVE-2026-2007 HIGH
libecpg-dev 18.1-r0 CVE-2026-2004 HIGH
libecpg-dev 18.1-r0 CVE-2026-2005 HIGH
libecpg-dev 18.1-r0 CVE-2026-2006 HIGH
libecpg-dev 18.1-r0 CVE-2026-2007 HIGH
libpq 18.1-r0 CVE-2026-2004 HIGH
libpq 18.1-r0 CVE-2026-2005 HIGH
libpq 18.1-r0 CVE-2026-2006 HIGH
libpq 18.1-r0 CVE-2026-2007 HIGH
libpq-dev 18.1-r0 CVE-2026-2004 HIGH
libpq-dev 18.1-r0 CVE-2026-2005 HIGH
libpq-dev 18.1-r0 CVE-2026-2006 HIGH
libpq-dev 18.1-r0 CVE-2026-2007 HIGH
postgresql18-dev 18.1-r0 CVE-2026-2004 HIGH
postgresql18-dev 18.1-r0 CVE-2026-2005 HIGH
postgresql18-dev 18.1-r0 CVE-2026-2006 HIGH
postgresql18-dev 18.1-r0 CVE-2026-2007 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
github-actions bot commented Feb 22, 2026

✨ Benchmark results

  • Requests per second: 2,003
  • Requests with 200 status code: 360,502
  • P99 latency: 0.077947429

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 2,003 1,145
200 360,502 206,155
P99 0.077947429 0.183263456

@eldadfux eldadfux merged commit 0c83fa4 into 1.8.x Feb 24, 2026
108 of 110 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Feb 25, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loks0n loks0n loks0n approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eldadfux @loks0n
0