8000 Update TanStack root directory by Meldiron · Pull Request #10860 · appwrite/appwrite · GitHub
[go: up one dir, main page]
Skip to content

Update TanStack root directory #10860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Meldiron merged 3 commits into from
Nov 24, 2025
Merged

Update TanStack root directory #10860

Meldiron merged 3 commits into from
Nov 24, 2025

Conversation

@Meldiron
Copy link
Contributor
@Meldiron Meldiron commented Nov 24, 2025

What does this PR do?

Changes root directory of default tanstack project, since their CLI now defaults to Nitro

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Contributor
coderabbitai bot commented Nov 24, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

Two changes: (1) In app/config/frameworks.php the TanStack Start SSR adapter outputDirectory was changed from './dist' to './.output'. (2) In composer.json the dependency entry for utopia-php/vcs was changed from the version constraint "0.12.*" to the explicit alias "dev-fix-tanstack-nitro-default as 0.12.99". No other modifications are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review the app/config/frameworks.php change to ensure build/runtime tooling expects ./.output (Nitro/TanStack SSR output path).
  • Verify the composer.json alias is intentional: check composer.lock changes, confirm the aliased branch exists and that autoload/installation behaves as expected.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the motivation behind the changes (TanStack CLI now defaults to Nitro), which aligns with the actual modifications to the frameworks configuration and dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'Update TanStack root directory' directly aligns with the main change documented in the raw_summary - the outputDirectory path change from './dist' to './.output' for the tanstack-start SSR adapter, reflecting adaptation to the TanStack CLI's new Nitro default.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-tanstack-nitro-default

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
github-actions bot commented Nov 24, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
imagemagick 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-c++ 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-dev 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-heic 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-jpeg 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-jxl 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-libs 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-openexr 7.1.2.3-r0 CVE-2025-62171 HIGH
imagemagick-webp 7.1.2.3-r0 CVE-2025-62171 HIGH
libecpg 17.6-r0 CVE-2025-12818 HIGH
libecpg-dev 17.6-r0 CVE-2025-12818 HIGH
libpq 17.6-r0 CVE-2025-12818 HIGH
libpq-dev 17.6-r0 CVE-2025-12818 HIGH
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
postgresql17-dev 17.6-r0 CVE-2025-12818 HIGH
github.com/containerd/containerd/v2 v2.0.2 CVE-2024-25621 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH
stdlib 1.22.10 CVE-2025-58183 HIGH
stdlib 1.22.10 CVE-2025-58186 HIGH
stdlib 1.22.10 CVE-2025-58187 HIGH
stdlib 1.22.10 CVE-2025-58188 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

coderabbitai[bot]
coderabbitai bot reviewed Nov 24, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66afd10 and 13a7ead.

📒 Files selected for processing (1)
  • app/config/frameworks.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Linter
  • GitHub Check: scan
🔇 Additional comments (1)
app/config/frameworks.php (1)

218-218: Output directory change is correct for Nitro adapter, but verify helper scripts are compatible.

TanStack Start with Nitro adapter (v2 or v3) outputs to ./.output, not ./dist, so the change at line 218 is correct and aligns with the PR description.

However, two issues remain:

  1. PR title mismatch: The PR title says "Add teamId to project array in e2e test" but the actual change is only in frameworks.php line 218. Update the PR title to match the actual changes.

  2. Helper script compatibility: The helper scripts referenced at line 219 could not be located in the repository. Please verify that helpers/tanstack-start/server.sh and any related build/bundle scripts (line 211) are compatible with the new ./.output directory structure and do not have hardcoded references to ./dist.

@github-actions
Copy link
github-actions bot commented Nov 24, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,312
  • Requests with 200 status code: 236,140
  • P99 latency: 0.150687955

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,312 1,415
200 236,140 254,752
P99 0.150687955 0.146515805

@Meldiron Meldiron changed the title Add teamId to project array in e2e test Update TanStack root directory Nov 24, 2025
@Meldiron Meldiron requested a review from stnguyen90 November 24, 2025 18:09
@Meldiron Meldiron merged commit 8e70a52 into 1.8.x Nov 24, 2025
71 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Meldiron @stnguyen90
0