8000 Fix: tanstack builds crashing by Meldiron · Pull Request #10767 · appwrite/appwrite · GitHub
[go: up one dir, main page]
Skip to content

Fix: tanstack builds crashing #10767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Meldiron merged 1 commit into from
Nov 5, 2025
Merged

Fix: tanstack builds crashing #10767

Meldiron merged 1 commit into from
Nov 5, 2025
+4 −1
8000

Conversation

@Meldiron
Copy link
Contributor
@Meldiron Meldiron commented Nov 5, 2025

What does this PR do?

With minimal specs on Cloud, which is enforced by free tier, even small tanstack sites can fail to build, running out of memory. This is temporary solution to make such builds work well.

Test Plan

None

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Contributor
coderabbitai bot commented Nov 5, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

This pull request modifies the memory allocation logic in the Builds worker. Specifically, it extends the condition that triggers minimum memory allocation to 4096 MB during deployment builds. Previously, this allocation occurred only for the 'analog' resource framework; now it also triggers for the 'tanstack-start' resource framework. The change is a single conditional expansion in the build process.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file modification with minimal logic change (adding an OR condition to an existing check)
  • Follows an established pattern without introducing new complexity
  • No structural or architectural changes

Possibly related PRs

Suggested reviewers

  • vermakhushboo
  • eldadfux

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: increasing memory limits for tanstack framework builds to prevent crashes on resource-constrained Cloud environments.
Description check ✅ Passed The description clearly relates to the changeset by explaining the motivation (tanstack builds failing due to memory constraints) and the solution (temporary memory increase).
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-tanstack-builds
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ce2426 and e93f479.

📒 Files selected for processing (1)
  • src/Appwrite/Platform/Modules/Functions/Workers/Builds.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
🔇 Additional comments (1)
src/Appwrite/Platform/Modules/Functions/Workers/Builds.php (1)

592-597: Framework identifier verified—code change is correct.

The 'tanstack-start' identifier is confirmed throughout the codebase configuration and is the correct framework key. The logic properly extends memory allocation to both 'analog' and 'tanstack-start' frameworks to prevent OOM failures on constrained Cloud instances.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
github-actions bot commented Nov 5, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.44-r2 CVE-2025-5244 HIGH
binutils 2.44-r2 CVE-2025-5245 HIGH
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
pcre2 10.43-r1 CVE-2025-58050 CRITICAL
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH
stdlib 1.22.10 CVE-2025-47912 HIGH
stdlib 1.22.10 CVE-2025-58183 HIGH
stdlib 1.22.10 CVE-2025-58186 HIGH
stdlib 1.22.10 CVE-2025-58187 HIGH
stdlib 1.22.10 CVE-2025-58188 HIGH
stdlib 1.22.10 CVE-2025-61724 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
github-actions bot commented Nov 5, 2025

✨ Benchmark results

  • Requests per second: 1,141
  • Requests with 200 status code: 205,423
  • P99 latency: 0.169172691

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,141 1,166
200 205,423 209,989
P99 0.169172691 0.176178627

@Meldiron Meldiron merged commit b3f9404 into 1.8.x Nov 5, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loks0n loks0n loks0n approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Meldiron @loks0n
0