8000 fix: execution status enum description by ChiragAgg5k · Pull Request #10702 · appwrite/appwrite · GitHub
[go: up one dir, main page]
Skip to content

fix: execution status enum description #10702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lohanidamodar merged 2 commits into from
Oct 27, 2025
Merged

fix: execution status enum description #10702

lohanidamodar merged 2 commits into from
Oct 27, 2025

Conversation

@ChiragAgg5k
Copy link
Member
@ChiragAgg5k ChiragAgg5k commented Oct 25, 2025

No description provided.

@coderabbitai
Copy link
Contributor
coderabbitai bot commented Oct 25, 2025 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (6)
  • app/config/specs/open-api3-latest-client.json is excluded by !app/config/specs/**
  • app/config/specs/open-api3-latest-console.json is excluded by !app/config/specs/**
  • app/config/specs/open-api3-latest-server.json is excluded by !app/config/specs/**
  • app/config/specs/swagger2-latest-client.json is excluded by !app/config/specs/**
  • app/config/specs/swagger2-latest-console.json is excluded by !app/config/specs/**
  • app/config/specs/swagger2-latest-server.json is excluded by !app/config/specs/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This pull request updates the status field validation rule in the Execution response model to accept an additional enum value: "scheduled". The change adds this new value to the existing enum constraint and updates the corresponding field description. This is a localized modification to the model's field definition with no impact on surrounding logic or functionality.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • The change is a straightforward enum extension with no logic modifications
  • Single file modification with minimal scope
  • Verify that the "scheduled" status value aligns with backend workflow state machine expectations
  • Confirm the updated field description accurately represents all valid status values

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning No pull request description was provided by the author. While the check is intentionally lenient and only requires the description to be somehow related to the changeset, an empty description conveys no information and therefore fails to establish any relation to the changes made. The description does not describe any part of the changeset, nor does it provide meaningful context for the modification. The author should add a description explaining the purpose of the change, such as why the "scheduled" enum value is being added to the execution status field and what problem or requirement this addresses. Even a brief explanation of the rationale would satisfy the requirement.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "fix: execution status enum description" refers to a real aspect of the changeset. The summary confirms that the change includes updating the status field rule for Execution to include a new enum value "scheduled" and reflecting this in both the description and enum list. While the title emphasizes the description update rather than the primary addition of the "scheduled" enum value, it is clearly and specifically related to the changes made and is sufficiently descriptive for someone reviewing the commit history.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
github-actions bot commented Oct 25, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.44-r2 CVE-2025-5244 HIGH
binutils 2.44-r2 CVE-2025-5245 HIGH
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
pcre2 10.43-r1 CVE-2025-58050 CRITICAL
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
github-actions bot commented Oct 25, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,210
  • Requests with 200 status code: 217,790
  • P99 latency: 0.160947744

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,210 1,244
200 217,790 223,956
P99 0.160947744 0.163680294

@lohanidamodar lohanidamodar self-requested a review October 27, 2025 04:52
lohanidamodar
lohanidamodar approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member
@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Don't we need to generate spec, docs anything?

@pkg-pr-new
Copy link
pkg-pr-new bot commented Oct 27, 2025

Open in StackBlitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@10702

commit: 22f44c5

@lohanidamodar lohanidamodar merged commit 15b1255 into 1.8.x Oct 27, 2025
43 checks passed
@lohanidamodar lohanidamodar deleted the fix-description branch October 27, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lohanidamodar lohanidamodar lohanidamodar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChiragAgg5k @lohanidamodar
0