8000 Fix undefined sequence by lohanidamodar · Pull Request #10652 · appwrite/appwrite · GitHub
[go: up one dir, main page]
Skip to content

Fix undefined sequence #10652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lohanidamodar merged 1 commit into from
Oct 16, 2025
Merged

Fix undefined sequence #10652

lohanidamodar merged 1 commit into from
Oct 16, 2025

Conversation

@lohanidamodar
Copy link
Member
@lohanidamodar lohanidamodar commented Oct 16, 2025

What does this PR do?

  • Fix warning undefined $sequence

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Contributor
coderabbitai bot commented Oct 16, 2025 •
edited
Loading

Caution

Review failed

Failed to post review comments

📝 Walkthrough

Walkthrough

This PR introduces broad updates: adds _APP_DNS and _APP_DOMAIN_TARGET_CAA, removes issue auto-labeling config/workflow, adds a locale static-analysis step and Node script, updates tests workflow with response format and matrices, bumps Docker base image and README image tags, adjusts CLI resources, modifies multiple configs (collections, console, errors, events, roles/scopes, services with new TablesDB, platforms versions), revises email templates and translations (placeholders, previews, fonts), updates site/Flutter template, adds variables entries, and significantly refactors account API routes/method declarations (new endpoints plus deprecated aliases) with branded email handling and template validation.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Possibly related PRs

Suggested reviewers

  • eldadfux
  • loks0n
  • ItzNotABug

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “Fix undefined sequence” directly reflects the primary change of addressing an undefined sequence warning in the code. It is concise, specific, and uses clear terminology without extraneous details. A reviewer scanning the history can immediately understand the main purpose of this PR.
Description Check ✅ Passed The description clearly states that the PR fixes the undefined $sequence warning and aligns with the changes in the diff. Although it lacks detailed test instructions, it remains on topic and conveys the core purpose of the update. This level of description is acceptable under the lenient criteria.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-undefined-sequence

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
github-actions bot commented Oct 16, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.44-r2 CVE-2025-5244 HIGH
binutils 2.44-r2 CVE-2025-5245 HIGH
libxml2 2.13.8-r0 CVE-2025-49794 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49796 CRITICAL
libxml2 2.13.8-r0 CVE-2025-49795 HIGH
libxml2 2.13.8-r0 CVE-2025-6021 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@lohanidamodar lohanidamodar changed the base branch from main to 1.8.x October 16, 2025 04:45
@pkg-pr-new
Copy link
pkg-pr-new bot commented Oct 16, 2025

Open in StackBlitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@10652

commit: b63c280

@lohanidamodar lohanidamodar merged commit 8dfdfcb into 1.8.x Oct 16, 2025
49 of 88 checks passed
@github-actions
Copy link
github-actions bot commented Oct 16, 2025

✨ Benchmark results

  • Requests per second: 1,197
  • Requests with 200 status code: 215,568
  • P99 latency: 0.162706331

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,197 990
200 215,568 178,313
P99 0.162706331 0.192869676

@coderabbitai coderabbitai bot mentioned this pull request Oct 27, 2025
Open
2 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 6, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abnegate abnegate abnegate approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lohanidamodar @abnegate
0