8000 Add project name in email subject by hmacr · Pull Request #10609 · appwrite/appwrite · GitHub
[go: up one dir, main page]
Skip to content

Add project name in email subject #10609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Meldiron merged 2 commits into from
Oct 7, 2025
Merged

Add project name in email subject #10609

Meldiron merged 2 commits into from
Oct 7, 2025

Conversation

@hmacr
Copy link
Contributor
@hmacr hmacr commented Oct 6, 2025

@coderabbitai
Copy link
Contributor
coderabbitai bot commented Oct 6, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The email subject templates in app/config/locale/translations/en.json were updated to include the project context by appending {{project}}: emails.verification.subject is now "Account Verification for {{project}}", and emails.recovery.subject is now "Password Reset for {{project}}". Corresponding end-to-end tests in tests/e2e/Services/Account/AccountCustomClientTest.php were updated to expect the new subjects incorporating the project name. No other files or functional logic were changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • Meldiron

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title clearly summarizes the primary change of including the project name in email subjects by stating “Add project name in email subject,” which accurately describes the main update without extra noise.
Description Check ✅ Passed The pull request description links directly to the task tracking use of the project name in email subjects, which aligns with the changeset and is therefore related to the updates made.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ser-439
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3190d04 and cb70a6e.

📒 Files selected for processing (2)
  • app/config/locale/translations/en.json (2 hunks)
  • tests/e2e/Services/Account/AccountCustomClientTest.php (2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
tests/e2e/Services/Account/AccountCustomClientTest.php (2)
tests/e2e/Scopes/Scope.php (1)
  • getProject (150-150)
tests/e2e/Scopes/ProjectCustom.php (1)
  • getProject (21-184)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: E2E Service Test (Teams)
  • GitHub Check: E2E Service Test (Health)
  • GitHub Check: E2E Service Test (Messaging)
  • GitHub Check: E2E Service Test (Storage)
  • GitHub Check: E2E Service Test (Proxy)
  • GitHub Check: E2E Service Test (Projects)
  • GitHub Check: E2E Service Test (FunctionsSchedule)
  • GitHub Check: E2E Service Test (GraphQL)
  • GitHub Check: E2E Service Test (Locale)
  • GitHub Check: E2E Service Test (Databases/TablesDB)
  • GitHub Check: E2E Service Test (Account)
  • GitHub Check: E2E Service Test (Console)
  • GitHub Check: E2E Service Test (Functions)
  • GitHub Check: E2E Service Test (Databases/Legacy)
  • GitHub Check: E2E Service Test (Site Screenshots)
  • GitHub Check: E2E General Test
  • GitHub Check: E2E Service Test (Dev Keys)
  • GitHub Check: Unit Test
  • GitHub Check: Benchmark
  • GitHub Check: scan
🔇 Additional comments (4)
app/config/locale/translations/en.json (2)

6-6: LGTM! Good addition of project context.

The updated subject template correctly includes the {{project}} placeholder, consistent with other email subjects in this file. This improvement helps users identify which project the verification email pertains to, especially useful for users managing multiple projects.

49-49: ```bash
#!/bin/bash

Re-run with PCRE2 to find any locales missing the “for {{project}}” placeholder

fd --type f --extension json app/config/locale/translations/

rg -P -n '"emails.verification.subject":\s*"Account Verification"(?! for)' app/config/locale/translations/
rg -P -n '"emails.recovery.subject":\s*"Password Reset"(?! for)' app/config/locale/translations/


</blockquote></details>
<details>
<summary>tests/e2e/Services/Account/AccountCustomClientTest.php (2)</summary><blockquote>

`927-927`: **LGTM! Test correctly validates the new subject format.**

The assertion properly expects the verification email subject to include the project name, matching the template change in `en.json`.

---

`1231-1231`: **LGTM! Test correctly validates the new subject format.**

The assertion properly expects the recovery email subject to include the project name, consistent with the verification email test and matching the template change in `en.json`.

</blockquote></details>

</blockquote></details>

</details>

<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>

<!-- tips_end -->

<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKPR1AGxJcAgrXq8+CJikBhobChYJMzaHvbYwqK4kJAGAHKOApRcAIwADABseQCcKQYAqjYAMlywuLjciBwA9M1E6rAJGkzMzWjc3ADuFOokfQPDo83c2B4ezflFpanliNmQsDEMfKkAyvjYFAwkkAJUGAywXGsUYAAsAMzLBtDOpMlnmJe5GgAcGgAPMq7XDUbBNfjcMhlADCFBI1Do6E4kAATHlUQBWMD5MCFaA5AocO6YjionIALSMABFpNt4NxxPgMBwDFAbCQAGaUMjHZCgxAAa1q9UaLWaHng5GcWgG4yGIxozSQDjGuwAojZ7k9muCSGBAsFcGAwmwwFKwNFYmAHIkxEY0vhIPCJPASINKMh8HwPCoSB5kM4TpLEDRaBoYLATrZIOJcF5IrR4AxEfyo4xYJhSCh+U6pQwPNglLH04akqFwicpZArfA4rajYgANwlk5KRD0xnwZmQSUYQW51vO/2I+gCwWnPAKDCgqXIDBOtD+dTdsJxeDMbheNgz6iryBKWcBjRGfTGcBQMj0fCcnAEYhkZRhhSsdhcXj8O3iKQyeRMJRUKo6haDoZ4mFAcCoKgmB3oQpDkFQz49DuKJUIM8ROC4px/ooyhAZo2i6GAhjnqYBj9NwzRMBgnLwEQEr4CmXjNLg5yIL6TIYIgzRkBoQiIMyrIAEQiQYFiQD4ACSD4IaOGExFhN4Zlm0inpA5TcLQcm4IMTq1vWCRGrG0RbqmsZ5hchbFrgpYUEE5bUTQAIfPIFFXlKRBDqZxywPgHgAZAADegVlmIAC+YVcPpiAaFIIy0SmnEaA25YLuhQk+AwTDYDOkAAGqUPACV7j2nLekFIV2UaEVCQANOgGD0NFGjwkwcWyMlhmpfg6VWGgiCILpFD0ByazJGVfDBaFuA1SeUCOvwNmUJAnI5WIq5oHElwqV6fCUHZfCZo1faeUuQjgrgKFegINxSOGRinmRPgeDQiGroOS0HqIvpvcyXq3iQALcN6z7lTMAiSgwNYziuqlsqEzIkEY6qhhucn/icLpuuhXITSiACydDwI4BgiUJj1gEYNChtxJComqlCunyzSZdlM4s1lBwzjCF0sDCkrsNA0iaNwsDcMJoniVJMlPkiDiYfISnbRgpCIGpGlac++nxF+NZA0kJVcZExk0+ZkQFkWJyfdNFZsKyKRQKzXPJHFRXJobNYxHW849XrUIhJ9KUB06WSQBlnM5ckBXxe7nEreVlX2SEpokGFQmRKGCLXre4ds1HhXFZxQkng7kAcm1lCyNM/WDd69DwmNnuxD7OP6wH6ZB8kBCnCcQl9QNQ0jdIJDjQnNsp2nGc0Eu/A5/3tfDWXw+4MX8M+Jy3JiPywtwgiNBO5H0du4lq71dTuC74iB8zuX+DtfVmD1yOoNZYc8IXNIxvXxfvPMPzboziFqGDQotuBzUgAtVaFxOKbQUMWbg1BYC7WnKxPyK0PC+wwe0KGytVYtmZB4eQ58/YG04sgD08J0C0HOpne6D0pYvSfO9M2n0lAFmcIbf6fsQZIjBgkSG0M4xujVukRGyNUYxCQrhYcrp3Q1g3iDLghMkwkzJo9Ei4FobZ1gjLRCSJkJvmdGgdC8sFLyDkHAvCagCKgWIgYTRyF1AAH14C0EQE4rG7o6BONDM4ZIZ57EXkYAIAA7HkNABQ6YMF+I8HIAgGAFAKAIVEBQGB3BIJiNAvwBC/BIOkvIqgcgMFoHkPJRENFBMcbgFxbiPEkFkR6WgTirzlMCRAHg8InFsAoKQJxlxRADh8aCCg/i7EGECgYFIQkkC2AAEIYIYIKOgMIWAoSsPgWhQkuCck2msWqkyw6IF8rMWg8zGKClsFslauySD7KmUgAA8nFEY/gyBXJ2QGW5ByhJJloDYHK1JGIghGCrRAMIoyLKuaxbAXypm/P+Rgdw8YSDgoGVCigMK7lh3hQCukIwuzMlRZCrg0LYVhz7Es2gkkBowsQMCq5IksVCV9KGIlgpRqzFwIgK5ABtA5KQJkpCFWHfpiy0iVgZUihMbK6r8qFUJXxuBwTosxXKqZgNTJhCLlwIScBox2DjAmAsCIKCEPks4eAAAvT+1sRhmOUirE4Sl8xWQ8l5KqqVKzG21p3X89hQTiBVpAQAOAR+ACB65OXrqw+q6mIWqgBcAkgIMBAlx0Cvz0Wa9s9IshphOF7LA2BNKIiTR0A4yRAasTQAjJAJANCyuFVMhufk8CrgZQtXBn9yB0DoC2T6hqqzIGogwGtDV6BZvxd+Wt9aG1CWYLhBlgxnAYA8tO4VQlWrMlokQQ4JB3k3KxWu70dEpSbTZeKtgDL+3k2FWFA9QU1UiohYKc9u6dW0g7BO/cMq71TMVcqklGKyVro1b6LVradV6p4LMOI8IACOtLkjjoZHHClyAkytXjEQp0fb+oTkrYst1epZ7uqTskFO3qvYGS/IgeqybkywHQJKIgRtBgdCHB2xuj8cytnhBNTGz8kTd0+oWzWn8YhKDrT+sOTbCzarDgtNA60exdqUPQfqQ4kMEqwBROyvB4CIjNbxnkH9c3Di8BITAXdcOSYfbO+dOrF0UGXSrVd8qN00TojuvdnypNCSPe0NcZ6JU6s00XOVt65WCpnaK59wWw6AoYKGEFnkVlxTQKQVzv6A3/tjIB3zIHMCGwZQlpLbqK5UGzKgfIeQNB5DyAAUiTSmhjqAHAb2TAAzQkZ+PwfgPCMcsAG6+X8tx34NW6v1Zsw2sOc6lALqXSu3z/mT0eCCxekLjFSuguvUKsKByAC6TKWW4FsO+zscmhI5BUMUVJqIGAPC5HEnJISCi0AeAIYo+Rii0E5OEgoxQ7gFF+L8CJOQ7ghIYCUB4ITihoEU6iVEITORjZuyQEg2SSBFAeNO5l/UTs2Cla+sOWJUSciu2gRHYP6Yw4eEkhJWUCicjuCk34YT6YFDCZEhgxQBBvaySEn7RQCgPbuMUu4ovigMCR298me22lQF4CQLplBekxfcS0/QQA= -->

<!-- internal state end -->

@github-actions
Copy link
github-actions bot commented Oct 6, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.44-r2 CVE-2025-5244 HIGH
binutils 2.44-r2 CVE-2025-5245 HIGH
libexpat 2.7.1-r0 CVE-2025-59375 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link
github-actions bot commented Oct 6, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,186
  • Requests with 200 status code: 213,555
  • P99 latency: 0.164619459

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,186 973
200 213,555 175,143
P99 0.164619459 0.201807569

@Meldiron Meldiron merged commit f653348 into 1.8.x Oct 7, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Meldiron Meldiron Meldiron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hmacr @Meldiron
0