Feat: update facts on GitHub sites and functions #10593
Open
+30
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThe change updates src/Appwrite/Vcs/Comment.php by replacing the contents of the protected $tips array with a larger set of tip strings. No methods, signatures, control flow, or error handling were modified. The mechanism that selects a random tip remains unchanged. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/Appwrite/Vcs/Comment.php (2)
12-12: Consider removing the TODO comment.The TODO comment says "Add more tips", but this PR significantly expands the tips array from 3 to 31 entries. If the goal of adding more tips has been achieved, consider removing or updating this TODO.
Apply this diff if the TODO is no longer relevant:
- // TODO: Add more tips protected array $tips = [
14-15: Remove trailing whitespace and adjust metric phrasing.
- Delete trailing whitespace in src/Appwrite/Vcs/Comment.php to fix the pipeline failure.
- Change “50K GitHub stars” to “over 50K GitHub stars” (currently ~52.9K).
- Update “24K passionate developers” to “over 24K developers” or verify and adjust the exact Discord member count.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/Appwrite/Vcs/Comment.php(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Linter
src/Appwrite/Vcs/Comment.php
[error] 1-1: Pint: no_trailing_whitespace detected. Remove trailing whitespace in this file. (no_trailing_whitespace)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: scan
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/Appwrite/Vcs/Comment.php(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: E2E Service Test (Messaging)
- GitHub Check: E2E Service Test (Migrations)
- GitHub Check: E2E Service Test (Sites)
- GitHub Check: E2E Service Test (Users)
- GitHub Check: E2E Service Test (Health)
- GitHub Check: E2E Service Test (Projects)
- GitHub Check: E2E Service Test (Realtime)
- GitHub Check: E2E Service Test (Storage)
- GitHub Check: E2E Service Test (Proxy)
- GitHub Check: E2E Service Test (Avatars)
- GitHub Check: E2E Service Test (Console)
- GitHub Check: E2E Service Test (Functions)
- GitHub Check: E2E Service Test (GraphQL)
- GitHub Check: E2E Service Test (Databases)
- GitHub Check: E2E Service Test (Account)
- GitHub Check: E2E General Test
- GitHub Check: E2E Service Test (Dev Keys)
- GitHub Check: Unit Test
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: scan
🔇 Additional comments (1)
src/Appwrite/Vcs/Comment.php (1)
14-43: Tips content looks good overall.The expanded tip set provides valuable information about Appwrite's Sites and Functions features. The tips are:
- Clear and concise
- Technically accurate in their descriptions
- Well-organized by feature area
- Appropriate for display in GitHub PR comments
Comment on lines
+14
to
+15
| 'Appwrite has crossed the 50K GitHub stars milestone with hundreds of active contributors', | ||
| 'Discord community has grown to 24K passionate developers and counting', |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
Verify time-sensitive statistics before merging.
The GitHub stars (50K) and Discord community size (24K) are specific numbers that may become outdated quickly. Consider either:
- Verifying these numbers are current as of the merge date
- Making the messaging more general (e.g., "tens of thousands of stars", "thriving Discord community")
🌐 Web query:
What are the current GitHub star count for appwrite/appwrite repository and the current Discord community size for Appwrite?
💡 Result:
As of October 2, 2025:
- GitHub (appwrite/appwrite) stars: 52.9k. [1]
- Appwrite Discord community size: 23,922 members. [2]
Sources:
[1] appwrite/appwrite GitHub page.
[2] Appwrite server listing on Discord.
Update time-sensitive statistics
- Replace “50K GitHub stars” with “52.9K GitHub stars”
- Replace “24K passionate developers” with “23.9K passionate developers” (23,922 members)
Alternatively, generalize to reduce maintenance (e.g., “over 50K stars”, “thriving Discord community”).
🤖 Prompt for AI Agents
In src/Appwrite/Vcs/Comment.php around lines 14 to 15, update the time-sensitive
strings: replace "50K GitHub stars" with "52.9K GitHub stars" and replace "24K
passionate developers" with "23.9K passionate developers (23,922 members)";
alternatively, if you prefer less maintenance, change the phrases to non-exact
wording such as "over 50K stars" and "thriving Discord community"—pick one
approach and update both array entries accordingly.
✨ Benchmark results
⚡ Benchmark Comparison
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist