8000 Fix healthstatus enum by ChiragAgg5k · Pull Request #10540 · appwrite/appwrite · GitHub
[go: up one dir, main page]
Skip to content

Fix healthstatus enum #10540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abnegate merged 1 commit into from
Sep 24, 2025
Merged

Fix healthstatus enum #10540

abnegate merged 1 commit into from
Sep 24, 2025

Conversation

@ChiragAgg5k
Copy link
Member
@ChiragAgg5k ChiragAgg5k commented Sep 23, 2025

What does this PR do?

the naming conflicted -

Screenshot 2025-09-23 at 4 48 44 PM

Test Plan

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Contributor
coderabbitai bot commented Sep 23, 2025 •
edited
Loading

Caution

Review failed

Failed to post review comments

📝 Walkthrough

Walkthrough

Adds two new env vars (_APP_DNS, _APP_DOMAIN_TARGET_CAA) and wires them into console/variables. Updates GitHub workflows: adds a locale static-analysis step and expands tests (workflow_dispatch, response_format propagation, failure logs). Bumps Docker base image and README image tags. Introduces locale audit script and switches email templates to self-hosted fonts with preview support; updates many translations (placeholder changes, removals). Broad config updates: errors/events, roles/scopes, services (TablesDB), collections, avatars. Expands SDK/platform metadata (versions, changelogs). Controllers: significant API surface updates with deprecations (account, messaging), queue handling refactor in health, SVG sanitization in avatars, migrations internalFile, and adds rowsTotal in project usage. Minor CLI resource aliases.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Possibly related PRs

  • Feat tablesdb #10333 — Introduces/expands the TablesDB surface; overlaps with new tables/rows/columns scopes, services, events, and config in this PR.
  • deploy: fix queue health #10369 — Refactors health queue endpoints to use typed per-queue injections and getSize(); matches the health.php changes here.
  • Fix casing #10346 — Adds SDK deprecation metadata and dual MFA method names in account.php; aligns with the account API deprecation changes.

Suggested reviewers

  • loks0n

Pre-merge checks and finishing touches and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Fix healthstatus enum" is short, specific, and clearly describes the primary intent (resolving a naming conflict with the health status enum), which aligns with the health-related changes present in the diff (notably app/controllers/api/health.php). It is concise and sufficient for a teammate scanning history to understand the main change.
Description Check ✅ Passed The PR description states the change addresses a naming conflict for the healthstatus enum and includes a screenshot illustrating the issue, so it is related to the changeset and not off-topic; however it is brief and lacks explicit details like the exact enum values changed or a test plan.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-healthstatus-enum
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-healthstatus-enum

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ChiragAgg5k ChiragAgg5k changed the base branch from main to 1.8.x September 23, 2025 11:23
@github-actions
Copy link
github-actions bot commented Sep 23, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.7.1-r0 CVE-2025-59375 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH
golang.org/x/oauth2 v0.24.0 CVE-2025-22868 HIGH
stdlib 1.22.10 CVE-2025-47906 HIGH
stdlib 1.22.10 CVE-2025-47907 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@abnegate abnegate merged commit 7a31e1c into 1.8.x Sep 24, 2025
4 checks passed
@ChiragAgg5k ChiragAgg5k deleted the fix-healthstatus-enum branch September 24, 2025 02:09
@coderabbitai coderabbitai bot mentioned this pull request Nov 6, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abnegate abnegate abnegate approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChiragAgg5k @abnegate
0