Fixed plugin embedding build phase for macOS not being added on older versions of Unity #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DodgyTim
pushed a commit
to dodgy-ltd/apple-unityplugins
that referenced
this pull request
Nov 29, 2024
apple#45) New GameKit APIs for iOS/tvOS 18.0, macOS 15.0, and visionOS 2.0. * `GKGameCenterViewController.initWithLeaderboardSetID` and `.initWithPlayer` * `GKAccessPoint` new `Trigger*` methods. Other changes: * Add saved game APIs * Add Unity Editor UI for setting the iCloud container used for saving games. * Add saved game tests to the sample app. * Add default leaderboard APIs. * Add simpler availability queries by using C# reflection. * Improve handling of API unavailable errors by throwing exceptions in C#. * Add many availability annotations that were previously missing (allows running on iOS 13). * Improve handling of nil player, leaderboard, and achievement images. * Provide helpful explanations to developers via logging and sample app UI for certain GameKit exceptions and errors. * Improve navigation in the sample app on tvOS when using the remote. * Fix a bug that prevented paging of leaderboard entries. * Refactor and improve handling of GameKitException and GKErrorCode. Simplify the way explanatory messages are delivered to the developer when errors occur. * Set minimum OS targets to iOS/tvOS 13, macOS 10.15, and visionOS 1.0 to align with Apple Arcade. * Add byte array initializer to NSData wrapper. * Rename GKPlayer.FetchItems to FetchItemsForIdentityVerificationSignature. (But also keep shorter name for backwards-compatibility.) * Fine tune the auth flow to better handle the user signing out and back in to Game Center in system settings. * Improve the auth flow in the sample app and ensure exceptions are caught in the auth handler callbacks. * Make GKAccessPoint.FrameInUnitCoordinates() unavailable on visionOS. * Upgrade to Unity 2022.3.45f1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some older versions of Unity the
pbxProject.GetUnityMainTargetGuid()for macOS build target returns empty string. In some places in code there is a ternary operator to address this (e.g.AppleBuild.csline 176). The issue is fixed in newer versions of Unity.This PR adds ternary operator in two places where the workaround was missing. Without that the "Embed Apple Plug-in Libraries" build phase was never added to the Xcode project and there was an Error Log in the Unity console. (Tested in Unity 2021.3.16f1)