chore: Fix find_by_images_tests.py#495
Merged
ki4070ma merged 6 commits intoappium:masterfrom Jan 30, 2020
ki4070ma:fix-image-test
Merged
chore: Fix find_by_images_tests.py#495ki4070ma merged 6 commits intoappium:masterfrom ki4070ma:fix-image-test
ki4070ma merged 6 commits intoappium:masterfrom
ki4070ma:fix-image-test
Conversation
ki4070ma
commented
Jan 29, 2020
| displayName: Install Node 11.x | ||
| - script: npm install -g appium@beta --chromedriver_version='2.44' | ||
| displayName: Install appium | ||
| - script: npm install -g opencv4nodejs |
Contributor
There was a problem hiding this comment.
how much longer the tests take now?
Collaborator
Author
There was a problem hiding this comment.
This installation step takes 8m46s.
In total, it's 20min.
https://dev.azure.com/ki4070ma/python-client/_build/results?buildId=1046&view=logs
Contributor
There was a problem hiding this comment.
what was the previous value (before enabling opencv)?
Collaborator
Author
There was a problem hiding this comment.
It's 10m30s previously.
Almost just added installation time.
https://dev.azure.com/ki4070ma/python-client/_build/results?buildId=1047
Contributor
There was a problem hiding this comment.
I'm ok with the change if such increase in tests execution duration works for you
mykola-mokhnach
approved these changes
Jan 30, 2020
KazuCocoa
approved these changes
Jan 30, 2020
ki4070ma
added a commit
that referenced
this pull request
Apr 26, 2020
* Update pytest-cov requirement from ~=2.6 to ~=2.8 (#489) Updates the requirements on [pytest-cov](https://github.com/pytest-dev/pytest-cov) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest-cov/releases) - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-cov@v2.6.0...v2.8.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update autopep8 requirement from ~=1.4 to ~=1.5 (#490) Updates the requirements on [autopep8](https://github.com/hhatto/autopep8) to permit the latest version. - [Release notes](https://github.com/hhatto/autopep8/releases) - [Commits](hhatto/autopep8@v1.4...v1.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update tox-travis requirement from ~=0.11 to ~=0.12 (#491) Updates the requirements on [tox-travis](https://github.com/tox-dev/tox-travis) to permit the latest version. - [Release notes](https://github.com/tox-dev/tox-travis/releases) - [Changelog](https://github.com/tox-dev/tox-travis/blob/master/HISTORY.rst) - [Commits](tox-dev/tox-travis@0.11...0.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update tox requirement from ~=3.6 to ~=3.14 (#494) Updates the requirements on [tox](https://github.com/tox-dev/tox) to permit the latest version. - [Release notes](https://github.com/tox-dev/tox/releases) - [Changelog](https://github.com/tox-dev/tox/blob/master/docs/changelog.rst) - [Commits](tox-dev/tox@3.6.0...3.14.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * chore: Fix find_by_images_tests.py (#495) * chore: Fix find_by_images_tests.py * Add installation opencv4nodejs * Fix typo * Add taking screen record to find_by_image_test * Fix errors on the emulator * Remove unused imports * feat: Add viewmatcher (#480) * Add android view matcher as strategy locator * Add docstring * Add functional test * Remove find_elements_by_android_data_matcher * Fix docstring * tweak docstring * Bump 0.50 * Update changelog for 0.50 * Fix flaky functional tests (#473) * Run all tests * Fix apk file path * Skip find_element_by_image test cases * Skip context switching test * Skip multi tap test on CI * Change strategy for waiting element * Add functions for same steps * Restore unexpected changes * Fix touch_action_tests * Fix * Fix Fix test_driver_swipe * fix * Create _move_to_[target_view] * [test_driver_swipe] Add wait * feat: Add idempotency key header to create session requests (#514) * feat: Override send_keys without file upload function (#515) * add send_keys_direct * override send_keys * tune * add unittest instead of functional test * tweak syntax * Bump 0.51 * Update changelog for 0.51 * test: Fix test_clear flaky functional test (#519) * test: Add unit test for set_value (setImmediateValue) (#518) * chore: Fix int - str comparison error in ios desired capabilities (#517) if number >= PytestXdistWorker.COUNT: TypeError: '>=' not supported between instances of 'int' and 'str' 2. Updated test case path and iPhone model in Readme file * fix: Handling of dictionary-values in WebElement.get_attribute() (#521) * Bump 0.52 * Update changelog for 0.52 * Fix mypy error * tweak * Add wait to test * Skip tap_twice test * review comments * Remove unnecessary import Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Kazuaki Matsuo <fly.49.89.over@gmail.com> Co-authored-by: Mykola Mokhnach <mokhnach@gmail.com> Co-authored-by: Nrupesh Patel <nrupesh.patel2912@gmail.com> Co-authored-by: Venkatesh <venkatesh@poshmark.com> Co-authored-by: Hannes Hauer <hanneshauer@beeware.at>
ki4070ma
added a commit
that referenced
this pull request
Apr 30, 2020
* Drop py2 support (#478) * Drop py2 support * Support 3.7+ * Add explicit type declarations (#482) * Fixed mypy warning: touch_action.py * Fixed mypy warning: multi_action.py * Fixed mypy warning: extensions/android * Fixed mypy warning: extensions/search_context * Updated * Revert some changes to run unit test * Review comments * Updates * Updates * Add mypy check to ci.sh * Add mypy to Pipfile * Updates * Update README * Revert unexpected changes * Updates Dict * Revert unexpected changes * Updates * Review comments * Review comments * tweak * Restore and modify changes * Fix wrong return type * Add comments * Revert unexpected changes * Fix mypy error * updates * Add mypy to pre-commit (#485) * chore: Applied some py3 formats (#486) * Removed unused import * Removed unnecessary codes * Applied f'' format instead ''.format() * Fixes * tweak * chore: Fix mypy errors under test folder (#487) * Fix mypy errors under test folder * Add mypy check for test folder to pre-commit * Add mypy check to ci * chore: Remove unittest dependency (#488) * Removed unnecessary codes from calling super * Removed unittest dependency * Upgrade the dependencies to the latest * Removed unused args * Review comments * Update mock requirement from ~=3.0 to ~=4.0 (#502) Updates the requirements on [mock](https://github.com/testing-cabal/mock) to permit the latest version. - [Release notes](https://github.com/testing-cabal/mock/releases) - [Changelog](https://github.com/testing-cabal/mock/blob/master/CHANGELOG.rst) - [Commits](testing-cabal/mock@3.0.0...4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Add 'from' to except (#503) * Update pre-commit requirement from ~=1.21 to ~=2.1 (#506) Updates the requirements on [pre-commit](https://github.com/pre-commit/pre-commit) to permit the latest version. - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/master/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v1.21.0...v2.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * doc: Add script to generate sphinx doc (#508) * Add quickstart template files * Update conf file * Update * Update settings * Change project name * Add script to generate docs * Changed header title * Add new line to usage section * Add py.typed file(PEP561) * Replace \n with new line * tweak * Use sphinx format for tables * Rebase python3 branch with master (#522) * Update pytest-cov requirement from ~=2.6 to ~=2.8 (#489) Updates the requirements on [pytest-cov](https://github.com/pytest-dev/pytest-cov) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest-cov/releases) - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-cov@v2.6.0...v2.8.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update autopep8 requirement from ~=1.4 to ~=1.5 (#490) Updates the requirements on [autopep8](https://github.com/hhatto/autopep8) to permit the latest version. - [Release notes](https://github.com/hhatto/autopep8/releases) - [Commits](hhatto/autopep8@v1.4...v1.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update tox-travis requirement from ~=0.11 to ~=0.12 (#491) Updates the requirements on [tox-travis](https://github.com/tox-dev/tox-travis) to permit the latest version. - [Release notes](https://github.com/tox-dev/tox-travis/releases) - [Changelog](https://github.com/tox-dev/tox-travis/blob/master/HISTORY.rst) - [Commits](tox-dev/tox-travis@0.11...0.12) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update tox requirement from ~=3.6 to ~=3.14 (#494) Updates the requirements on [tox](https://github.com/tox-dev/tox) to permit the latest version. - [Release notes](https://github.com/tox-dev/tox/releases) - [Changelog](https://github.com/tox-dev/tox/blob/master/docs/changelog.rst) - [Commits](tox-dev/tox@3.6.0...3.14.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * chore: Fix find_by_images_tests.py (#495) * chore: Fix find_by_images_tests.py * Add installation opencv4nodejs * Fix typo * Add taking screen record to find_by_image_test * Fix errors on the emulator * Remove unused imports * feat: Add viewmatcher (#480) * Add android view matcher as strategy locator * Add docstring * Add functional test * Remove find_elements_by_android_data_matcher * Fix docstring * tweak docstring * Bump 0.50 * Update changelog for 0.50 * Fix flaky functional tests (#473) * Run all tests * Fix apk file path * Skip find_element_by_image test cases * Skip context switching test * Skip multi tap test on CI * Change strategy for waiting element * Add functions for same steps * Restore unexpected changes * Fix touch_action_tests * Fix * Fix Fix test_driver_swipe * fix * Create _move_to_[target_view] * [test_driver_swipe] Add wait * feat: Add idempotency key header to create session requests (#514) * feat: Override send_keys without file upload function (#515) * add send_keys_direct * override send_keys * tune * add unittest instead of functional test * tweak syntax * Bump 0.51 * Update changelog for 0.51 * test: Fix test_clear flaky functional test (#519) * test: Add unit test for set_value (setImmediateValue) (#518) * chore: Fix int - str comparison error in ios desired capabilities (#517) if number >= PytestXdistWorker.COUNT: TypeError: '>=' not supported between instances of 'int' and 'str' 2. Updated test case path and iPhone model in Readme file * fix: Handling of dictionary-values in WebElement.get_attribute() (#521) * Bump 0.52 * Update changelog for 0.52 * Fix mypy error * tweak * Add wait to test * Skip tap_twice test * review comments * Remove unnecessary import Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Kazuaki Matsuo <fly.49.89.over@gmail.com> Co-authored-by: Mykola Mokhnach <mokhnach@gmail.com> Co-authored-by: Nrupesh Patel <nrupesh.patel2912@gmail.com> Co-authored-by: Venkatesh <venkatesh@poshmark.com> Co-authored-by: Hannes Hauer <hanneshauer@beeware.at> * chore: Update readme and gitchangelog section role (#524) (#525) * chore: tweak changelog filter * address stoping Python 2 support * 2 instead of 2.0... * tweak readme * Revert some unexpected changes * review comments * Changed bound for TypeVar * Fix crashing ci * Remove beta Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Kazuaki Matsuo <fly.49.89.over@gmail.com> Co-authored-by: Mykola Mokhnach <mokhnach@gmail.com> Co-authored-by: Nrupesh Patel <nrupesh.patel2912@gmail.com> Co-authored-by: Venkatesh <venkatesh@poshmark.com> Co-authored-by: Hannes Hauer <hanneshauer@beeware.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #373