8000 Fix isort behavior for mock by ki4070ma · Pull Request #432 · appium/python-client · GitHub
[go: up one dir, main page]
Skip to content

Fix isort behavior for mock #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ki4070ma merged 4 commits into from
Sep 10, 2019
+4 −11
Merged

Fix isort behavior for mock #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ae133b
Fix isort behavior for mock
ki4070ma Aug 26, 2019
df041be
Add guide to add 3rd party modules to isort conf
ki4070ma Aug 27, 2019
00303bf
Add guide for docstrings
ki4070ma Aug 27, 2019
68a503d
Delete unnecessary codes
ki4070ma Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .isort.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[settings]
multi_line_output = 3
known_third_party = dateutil,httpretty,pytest,selenium,setuptools,urllib3
known_third_party = dateutil,httpretty,pytest,selenium,setuptools,urllib3,mock
known_first_party = test
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ download and unarchive the source tarball (Appium-Python-Client-X.X.tar.gz).
```
$ python -m isort -rc .
```
- When you use newly 3rd party modules, add it to [.isort.cfg](.isort.cfg) to keep import order correct
- Docstring style: Google Style
- Refer [link](https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html)
- You can customise `CHANGELOG.rst` with commit messages following [.gitchangelog.rc](.gitchangelog.rc)
- It generates readable changelog
- Setup
Expand Down
10 changes: 0 additions & 10 deletions test/functional/android/activities_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,10 @@

import unittest

from appium import webdriver

from .helper import desired_capabilities
from .helper.test_helper import BaseTestCase


class ActivitiesTests(BaseTestCase):
def setUp(self):
desired_caps = desired_capabilities.get_desired_capabilities('ApiDemos-debug.apk')
self.driver = webdriver.Remote('http://localhost:4723/wd/hub', desired_caps)

def tearDown(self):
self.driver.quit()

def test_current_activity(self):
activity = self.driver.current_activity
self.assertEqual('.ApiDemos', activity)
Expand Down
0