8000 Fix android flaky tests by ki4070ma · Pull Request #413 · appium/python-client · GitHub
[go: up one dir, main page]

Skip to content

Fix android flaky tests#413

Merged
ki4070ma merged 7 commits intoappium:masterfrom
ki4070ma:fix-android-flaky-tests
Aug 26, 2019
Merged

Fix android flaky tests#413
ki4070ma merged 7 commits intoappium:masterfrom
ki4070ma:fix-android-flaky-tests

Conversation

@ki4070ma
Copy link
Collaborator
@ki4070ma ki4070ma commented Jul 7, 2019

For #377

Changes

  • Basically wait for target elements located
  • Extend various timeouts
  • Others

Remaining TODO in the next PR

  • Run chrome, touch_action, multi_action, find_by_accessibility_id, find_by_uiautomator

Target stability

10 times successes in a row
https://dev.azure.com/ki4070ma/python-client/_build?definitionId=2&_a=summary

[commit] Don't run flaky tests on CI

versionSpec: '11.x'
displayName: Install Node 11.x
- script: npm install -g appium --chromedriver_version='2.44'
- script: npm install -g appium@beta --chromedriver_version='2.44'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ki4070ma
Copy link
Collaborator Author
ki4070ma commented Jul 9, 2019

working in my local again https://github.com/ki4070ma/python-client/pull/5

@ki4070ma ki4070ma changed the title [WIP] Fix android flaky tests Fix android flaky tests Aug 17, 2019
self.driver.find_element_by_android_uiautomator('new UiSelector().text("Accessibility")').click()
self.driver.find_element_by_android_uiautomator('new UiSelector().text("Accessibility Node Querying")').click()
el = self.driver.find_element_by_class_name('android.widget.ListView')
if is_ci():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you find the cause?
I guess the uiautomator works fine if the app launched successfully.
Or uiautomator did not work in sometimes..

Copy link
Collaborator Author
@ki4070ma ki4070ma Aug 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you find the cause?

No for now.
Actually I can say the uiautomator works fine since other cases are ok.
And this case is ok on almost executions, but sometimes failed...

I'll look into more details after this PR.

@ki4070ma
Copy link
Collaborator Author
ki4070ma commented Aug 18, 2019

Triggered rebuild due to below error.

The agent: Azure Pipelines 6 lost communication with the server.
Verify the machine is running and has a healthy network connection.
For more information, see: https://go.microsoft.com/fwlink/?linkid=846610 

@ki4070ma
Copy link
Collaborator Author

will merge after #427

@ki4070ma ki4070ma mentioned this pull request Aug 20, 2019
@ki4070ma ki4070ma merged commit 106334c into appium:master Aug 26, 2019
@ki4070ma ki4070ma deleted the fix-android-flaky-tests branch August 26, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0