8000 Fix True/False in image settings, add boolean value in settings test by KazuCocoa · Pull Request #352 · appium/python-client · GitHub
[go: up one dir, main page]
Skip to content

Fix True/False in image settings, add boolean value in settings test #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazuCocoa merged 2 commits into from
Apr 23, 2019
Merged

Fix True/False in image settings, add boolean value in settings test #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a1e50c
Fix True/False in image settings, add boolean value in settings test
KazuCocoa Apr 22, 2019
f0a5610
use is for boolean
KazuCocoa Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/functional/android/find_by_image_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ def setUp(self):
self.driver = webdriver.Remote('http://localhost:4723/wd/hub', desired_caps)

# relax template matching
self.driver.update_settings({"fixImageFindScreenshotDims": "false",
"fixImageTemplateSize": "true",
"autoUpdateImageElementPosition": "true"})
self.driver.update_settings({"fixImageFindScreenshotDims": False,
"fixImageTemplateSize": True,
"autoUpdateImageElementPosition": True})

def tearDown(self):
self.driver.quit()
Expand Down
34 changes: 28 additions & 6 deletions test/unit/webdriver/device/settings_test.py
View file
Open in desktop
6109
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,45 @@
class TestWebDriverSettings(object):

@httpretty.activate
def test_get_settings(self):
def test_get_settings_bool(self):
driver = android_w3c_driver()
httpretty.register_uri(
httpretty.GET,
appium_command('/session/1234567890/appium/settings'),
body='{"value": {"sample": 123}}'
body='{"value": {"sample": true}}'
)
assert driver.get_settings()['sample'] == 123
assert driver.get_settings()['sample'] is True

@httpretty.activate
def test_update_settings(self):
def test_update_settings_bool(self):
driver = android_w3c_driver()
httpretty.register_uri(
httpretty.POST,
appium_command('/session/1234567890/appium/settings'),
)
assert isinstance(driver.update_settings({"sample": 123}), WebDriver) is True
assert isinstance(driver.update_settings({"sample": True}), WebDriver) is True

d = get_httpretty_request_body(httpretty.last_request())
assert d['settings']['sample'] == 123
assert d['settings']['sample'] is True

@httpretty.activate
def test_get_settings_string(self):
driver = android_w3c_driver()
httpretty.register_uri(
httpretty.GET,
appium_command('/session/1234567890/appium/settings'),
body='{"value": {"sample": "string"}}'
)
assert driver.get_settings()['sample'] == 'string'

@httpretty.activate
def test_update_settings_string(self):
driver = android_w3c_driver()
httpretty.register_uri(
httpretty.POST,
appium_command('/session/1234567890/appium/settings'),
)
assert isinstance(driver.update_settings({"sample": 'string'}), WebDriver) is True

d = get_httpretty_request_body(httpretty.last_request())
assert d['settings']['sample'] == 'string'
0