8000 JDK9 compatibility: replace DatatypeConverter with Base64 by valfirst · Pull Request #999 · appium/java-client · GitHub 8000
[go: up one dir, main page]
Skip to content

JDK9 compatibility: replace DatatypeConverter with Base64 #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SrinivasanTarget merged 1 commit into from
Aug 13, 2018
Merged

JDK9 compatibility: replace DatatypeConverter with Base64 #999

SrinivasanTarget merged 1 commit into from
Aug 13, 2018

Conversation

@valfirst
Copy link
Collaborator
@valfirst valfirst commented Aug 13, 2018

Change list

JDK9 compatibility: replace DatatypeConverter.parseBase64Binary(..) with Base64.getDecoder().decode(..)

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

SrinivasanTarget
SrinivasanTarget approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member
@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @valfirst

@SrinivasanTarget SrinivasanTarget merged commit 742db4e into appium:master Aug 13, 2018
@valfirst valfirst deleted the replace-datatypeconveter-with-base64 branch July 7, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saikrishna321 saikrishna321 saikrishna321 approved these changes

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@valfirst @saikrishna321 @mykola-mokhnach @SrinivasanTarget
0