8000 better handling of invocationtargetexception by SrinivasanTarget · Pull Request #968 · appium/java-client · GitHub
[go: up one dir, main page]
Skip to content

better handling of invocationtargetexception #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SrinivasanTarget merged 3 commits into from
Jul 5, 2018
Merged

better handling of invocationtargetexception #968

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44067df
better handling of invocationtargetexception
SrinivasanTarget Jul 4, 2018
adba94d
address review comments
SrinivasanTarget Jul 5, 2018
7ba51ad
address review comments
SrinivasanTarget Jul 5, 2018
File filter

Filter by extension

< 8000 input type="hidden" name="authenticity_token" value="mk-e_YVSTtX_AXlV8i146JwWWhpU_bjf-RrtafVVhh6-dvlsnhmFkR8D3KESh8xA5mPw0_4eUTmRsM0WRLJvaw" autocomplete="off" />
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/io/appium/java_client/remote/AppiumCommandExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,13 +191,16 @@ public Result createSession(HttpClient client, Command command)
return toReturn;
}).orElseThrow(() -> new SessionNotCreatedException(
format("Unable to create new remote session. desired capabilities = %s", desired)));
} catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) {
} catch (NoSuchMethodException | IllegalAccessException e) {
throw new WebDriverException(format("It is impossible to create a new session "
+ "because 'createSession' which takes %s, %s and %s was not found "
+ "or it is not accessible",
HttpClient.class.getSimpleName(),
InputStream.class.getSimpleName(),
long.class.getSimpleName()), e);
} catch (InvocationTargetException e) {
throw new SessionNotCreatedException(
format("Unable to create new remote session. Desired capabilities: %s", desired), e);
}
} finally {
os.reset();
Expand Down
0