8000 Fix #924 by SrinivasanTarget · Pull Request #951 · appium/java-client · GitHub 8000
[go: up one dir, main page]
Skip to content

Fix #924 #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SrinivasanTarget merged 2 commits into from
Jun 20, 2018
Merged

Fix #924 #951

SrinivasanTarget merged 2 commits into from
Jun 20, 2018

Conversation

@SrinivasanTarget
Copy link
Member
@SrinivasanTarget SrinivasanTarget commented Jun 19, 2018

Change list

Fix payload for legacy OSS mode.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Payload for MJSWP will look like below,

{
  "desiredCapabilities": {
    "app": "/Users/ssekar/workspace/java-client/src/test/java/io/appium/java_client/TestApp.app.zip",
    "platformVersion": "11.3",
    "automationName": "XCuiTest",
    "browserName": "",
    "platformName": "iOS",
    "deviceName": "iPhone 8",
    "launchTimeout": 500000
  }
}

payload for W3c will look like below,

{
  "desiredCapabilities": {
    "app": "/Users/ssekar/workspace/java-client/src/test/java/io/appium/java_client/TestApp.app.zip",
    "platformVersion": "11.3",
    "automationName": "XCuiTest",
    "browserName": "",
    "platformName": "iOS",
    "deviceName": "iPhone 8",
    "launchTimeout": 500000
  },
  "capabilities": {
    "alwaysMatch": {
      "appium:app": "/Users/ssekar/workspace/java-client/src/test/java/io/appium/java_client/TestApp.app.zip",
      "appium:automationName": "XCuiTest",
      "browserName": "",
      "appium:deviceName": "iPhone 8",
      "appium:launchTimeout": 500000,
      "platformName": "ios",
      "appium:platformVersion": "11.3"
    },
    "firstMatch": [
      {
        
      }
    ]
  }
}

mykola-mokhnach
mykola-mokhnach reviewed Jun 19, 2018
View reviewed changes
src/main/java/io/appium/java_client/remote/NewAppiumSessionPayload.java Outdated
// And write the first capability for gecko13
json.name(CAPABILITIES);
json.beginObject();
if(!forceMobileJSONWP) {
Copy link
Contributor
@mykola-mokhnach mykola-mokhnach Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space

@SrinivasanTarget SrinivasanTarget merged commit 29d3473 into appium:master Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@TikhomirovSergey TikhomirovSergey Awaiting requested review from TikhomirovSergey

@dpgraham dpgraham 53E1 Awaiting requested review from dpgraham

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SrinivasanTarget @KazuCocoa @mykola-mokhnach
0