8000 Switch web socket client implementation to okhttp library by mykola-mokhnach · Pull Request #941 · appium/java-client · GitHub
[go: up one dir, main page]
Skip to content

Switch web socket client implementation to okhttp library #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mykola-mokhnach merged 1 commit into from
Jun 13, 2018
Merged

Switch web socket client implementation to okhttp library #941

mykola-mokhnach merged 1 commit into from
Jun 13, 2018

Conversation

@mykola-mokhnach
Copy link
Contributor
@mykola-mokhnach mykola-mokhnach commented Jun 13, 2018

Change list

Selenium anyway uses okhttp, so it is a good idea to reuse it to interact with web sockets. Also this allows to get rid of some not really necessary dependencies.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mykola-mokhnach mykola-mokhnach merged commit 05fa225 into appium:master Jun 13, 2018
@mykola-mokhnach mykola-mokhnach deleted the ok_http_ws branch August 7, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

@TikhomirovSergey TikhomirovSergey Awaiting requested review from TikhomirovSergey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mykola-mokhnach @SrinivasanTarget
0