8000 Update to Selenium 3.8.1 by TikhomirovSergey · Pull Request #797 · appium/java-client · GitHub
[go: up one dir, main page]
Skip to content

Update to Selenium 3.8.1 #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TikhomirovSergey merged 1 commit into from
Dec 24, 2017
Merged

Update to Selenium 3.8.1 #797

TikhomirovSergey merged 1 commit into from
Dec 24, 2017

Conversation

@TikhomirovSergey
Copy link
Contributor
@TikhomirovSergey TikhomirovSergey commented Dec 23, 2017

Change list

  • Update to Selenium 3.8.1
  • Removal of deprecated listener-methods from the AlertEventListener. These methods were
    being invoked before/after authentication.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@TikhomirovSergey
Update to Selenium 3.8.1
0ae158a 
Removal of deprecated listener-methods from the AlertEventListener. These methods were
being invoked before/after authentication.
SrinivasanTarget
SrinivasanTarget approved these changes Dec 24, 2017
View reviewed changes
Copy link
Member
@SrinivasanTarget SrinivasanTarget left a comment
9201

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TikhomirovSergey TikhomirovSergey merged commit 953b106 into appium:master Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TikhomirovSergey @mykola-mokhnach @SrinivasanTarget
0