8000 test: Run tests on the JUnit Jupiter Platform by RameshBabuPrudhvi · Pull Request #1721 · appium/java-client · GitHub
[go: up one dir, main page]
Skip to content

test: Run tests on the JUnit Jupiter Platform#1721

Merged
mykola-mokhnach 8000 merged 23 commits intoappium:masterfrom
RameshBabuPrudhvi:junit5-migration
Jul 28, 2022
Merged

test: Run tests on the JUnit Jupiter Platform#1721
mykola-mokhnach merged 23 commits intoappium:masterfrom
RameshBabuPrudhvi:junit5-migration

Conversation

@RameshBabuPrudhvi
Copy link
Contributor
@RameshBabuPrudhvi RameshBabuPrudhvi commented Jul 25, 2022

Change list

Please provide briefly described change list which are you going to propose.

Migration of Java tests from JUnit 4 to JUnit 5

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@linux-foundation-easycla
Copy link
linux-foundation-easycla bot commented Jul 25, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: RameshBabuPrudhvi / name: Ramesh Babu Prudhvi (dcfdbbe)

@RameshBabuPrudhvi RameshBabuPrudhvi changed the title Run tests on the JUnit Platform Run tests on the JUnit Jupiter Platform Jul 25, 2022
valfirst
valfirst requested changes Jul 25, 2022
View reviewed changes
valfirst
valfirst requested changes Jul 26, 2022
View reviewed changes
@RameshBabuPrudhvi
Copy link
Contributor Author
RameshBabuPrudhvi commented Jul 26, 2022 •
edited
Loading

Resolved all review comments

valfirst
valfirst requested changes Jul 26, 2022
View reviewed changes
@RameshBabuPrudhvi
refactor!: Added Test annotation for all test override methods
8fd7141
@RameshBabuPrudhvi
refactor!: Reverted Widget Tests
b4b026d
@RameshBabuPrudhvi
Widget Tests (#1)
589709b 
* refactor!: Updated WidgetTests

* refactor!: Updated Widget Tests

* refactor!: Reverted format

* refactor!: cleanup

* refactor!: cleanup
@RameshBabuPrudhvi
Copy link
Contributor Author
RameshBabuPrudhvi commented Jul 28, 2022

Anyother comments on this

@mykola-mokhnach mykola-mokhnach changed the title Run tests on the JUnit Jupiter Platform test: Run tests on the JUnit Jupiter Platform Jul 28, 2022
@mykola-mokhnach mykola-mokhnach merged commit da326d6 into appium:master Jul 28, 2022
@RameshBabuPrudhvi RameshBabuPrudhvi deleted the junit5-migration branch July 29, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valfirst valfirst valfirst approved these changes

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RameshBabuPrudhvi @valfirst @mykola-mokhnach @SrinivasanTarget
0