8000 fix: chinese garbled characters #1617 by jasonjiang9527 · Pull Request #1618 · appium/java-client · GitHub
[go: up one dir, main page]
Skip to content

fix: chinese garbled characters #1617#1618

Merged
mykola-mokhnach merged 3 commits intoappium:masterfrom
jasonjiang9527:master
Dec 27, 2021
Merged

fix: chinese garbled characters #1617#1618
mykola-mokhnach merged 3 commits intoappium:masterfrom
jasonjiang9527:master

Conversation

@jasonjiang9527
Copy link
Contributor
@jasonjiang9527 jasonjiang9527 commented Dec 24, 2021 •
edited
Loading

fix #1617

Change list

avoid chinese garbled characters

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

details #1617

@linux-foundation-easycla
Copy link
linux-foundation-easycla bot commented Dec 24, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

mykola-mokhnach
mykola-mokhnach reviewed Dec 24, 2021
View reviewed changes
src/main/java/io/appium/java_client/service/local/AppiumDriverLocalService.java Outdated
checkNotNull(consumer, "consumer parameter is NULL!");
addOutPutStream(new OutputStream() {
StringBuilder lineBuilder = new StringBuilder();
private ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
Copy link
Contributor
@mykola-mokhnach mykola-mokhnach Dec 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the property be final?

Copy link
Contributor Author
@jasonjiang9527 jasonjiang9527 Dec 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes , final is better

@mykola-mokhnach
Copy link
Contributor
mykola-mokhnach commented Dec 24, 2021

Could you please sign the CLA?

@jasonjiang9527
Copy link
Contributor Author
jasonjiang9527 commented Dec 24, 2021

will CLA affect my pr?

@mykola-mokhnach
Copy link
Contributor
mykola-mokhnach commented Dec 24, 2021

I cannot merge it without CLA being signed

@jasonjiang9527
Copy link
Contributor Author
jasonjiang9527 commented Dec 24, 2021

👌i will do this later

@mykola-mokhnach mykola-mokhnach merged commit 1c28134 into appium:master Dec 27, 2021
@rishikhanna1401
Copy link
rishikhanna1401 commented Mar 10, 2022

@mykola-mokhnach I am facing issue with latest java-client to launch appium service. Does anything changed around this?

While trying to programmatically open appium server using java-client 8.0.0 I see below error msg:

io.appium.java_client.service.local.AppiumServerHasNotBeenStartedLocallyException: The local appium server has not been started. The given Node.js executable: /usr/local/bin/appium Arguments: [/usr/local/lib/node_modules/appium/lib/appium.js, --port, 18384, --address, 0.0.0.0]
Process output: usage: /usr/local/lib/node_modules/appium/build/lib/main.js
[-h] [–shell] [–allow-cors] [–reboot] [–ipa IPA] [-a ADDRESS]
[-p PORT] [-pa BASEPATH] [-ka KEEPALIVETIMEOUT] [-ca CALLBACKADDRESS]
[-cp CALLBACKPORT] [-bp BOOTSTRAPPORT] [-r BACKENDRETRIES]
[–session-override] [-l] [-g LOGFILE]
[–log-level {info,info:debug,info:info,info:warn,info:error,warn,warn:debug,warn:info,warn:warn,warn:error,error,error:debug,error:info,error:warn,error:error,debug,debug:debug,debug:info,debug:warn,debug:error}]
[–log-timestamp] [–local-timezone] [–log-no-colors] [-G WEBHOOK]
[–safari] [–default-device] [–force-iphone] [–force-ipad]
[–tracetemplate AUTOMATIONTRACETEMPLATEPATH]
[–instruments INSTRUMENTSPATH] [–nodeconfig NODECONFIG]
[-ra ROBOTADDRESS] [-rp ROBOTPORT]
[–chromedriver-executable CHROMEDRIVEREXECUTABLE] [–show-config]
[–no-perms-check] [–strict-caps] [–isolate-sim-device]
[–tmp TMPDIR] [–trace-dir TRACEDIR] [–debug-log-spacing]
[–suppress-adb-kill-server] [–long-stacktrace]
[–webkit-debug-proxy-port WEBKITDEBUGPROXYPORT]
[–webdriveragent-port WDALOCALPORT] [-dc DEFAULTCAPABILITIES]
[–relaxed-security] [–allow-insecure ALLOWINSECURE]
[–deny-insecure DENYINSECURE]
[–command-timeout DEFAULTCOMMANDTIMEOUT] [-k]
[–platform-name PLATFORMNAME] [–platform-version PLATFORMVERSION]
[–automation-name AUTOMATIONNAME] [–device-name DEVICENAME]
[–browser-name BROWSERNAME] [–app APP] [-lt LAUNCHTIMEOUT]
[–language LANGUAGE] [–locale LOCALE] [-U UDID]
[–orientation ORIENTATION] [–no-reset] [–full-reset]
[–app-pkg APPPACKAGE] [–app-activity APPACTIVITY]
[–app-wait-package APPWAITPACKAGE]
[–app-wait-activity APPWAITACTIVITY]
[–device-ready-timeout DEVICEREADYTIMEOUT]
[–android-coverage ANDROIDCOVERAGE] [–avd AVD] [–avd-args AVDARGS]
[–use-keystore] [–keystore-path KEYSTOREPATH]
[–keystore-password KEYSTOREPASSWORD] [–key-alias KEYALIAS]
[–key-password KEYPASSWORD] [–intent-action INTENTACTION]
[–intent-category INTENTCATEGORY] [–intent-flags INTENTFLAGS]
[–intent-args OPTIONALINTENTARGUMENTS] [–dont-stop-app-on-reset]
[–calendar-format CALENDARFORMAT] [–native-instruments-lib]
[–keep-keychains] [–localizable-strings-dir LOCALIZABLESTRINGSDIR]
[–show-ios-log] [–async-trace] [–chromedriver-port CHROMEDRIVERPORT]
[–log-filters LOGFILTERS] [-v]
/usr/local/lib/node_modules/appium/build/lib/main.js: error: unrecognized arguments: /usr/local/lib/node_modules/appium/lib/appium.js

Sample Start-up code(worked on java-client 8.0.0-beta version:

service = AppiumDriverLocalService
.buildService(new AppiumServiceBuilder()
.usingDriverExecutable(new File("/usr/local/bin/appium"))
.withAppiumJS(
new File(
“/usr/local/lib/node_modules/appium/lib/appium.js”))
.usingPort(port));
service.start();

Appium Version Used: 1.20.0 and 1.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valfirst valfirst valfirst left review comments

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AppiumDriverLocalService.addLogMessageConsumer(Consumer<String>) supply garbled characters in chinese words , 中文字符乱码

4 participants

@jasonjiang9527 @mykola-mokhnach @rishikhanna1401 @valfirst
0