chore: Add WDA-related XCUITestOptions#1552
Merged
mykola-mokhnach merged 2 commits intoappium:masterfrom Oct 26, 2021
Merged
Conversation
valfirst
approved these changes
Oct 26, 2021
Comment on lines
+52
to
+53
| Optional.ofNullable(args).ifPresent((v) -> result.put("args", v)); | ||
| Optional.ofNullable(env).ifPresent((v) -> result.put("env", v)); |
Collaborator
There was a problem hiding this comment.
minor: parenthesis could be removed
Suggested change
| Optional.ofNullable(args).ifPresent((v) -> result.put("args", v)); | |
| Optional.ofNullable(env).ifPresent((v) -> result.put("env", v)); | |
| Optional.ofNullable(args).ifPresent(v -> result.put("args", v)); | |
| Optional.ofNullable(env).ifPresent(v -> result.put("env", v)); |
Contributor
Author
There was a problem hiding this comment.
I prefer to keep them for better readability
Comment on lines
64
to
70
| .map((v) -> { | ||
| try { | ||
| return (v instanceof URL) ? (URL) v : new URL(String.valueOf(v)); | ||
| } catch (MalformedURLException e) { | ||
| throw new IllegalArgumentException(e); | ||
| } | ||
| }); |
Collaborator
There was a problem hiding this comment.
minor:
Suggested change
| .map((v) -> { | |
| try { | |
| return (v instanceof URL) ? (URL) v : new URL(String.valueOf(v)); | |
| } catch (MalformedURLException e) { | |
| throw new IllegalArgumentException(e); | |
| } | |
| }); | |
| .map(v -> { | |
| try { | |
| return v instanceof URL ? (URL) v : new URL(String.valueOf(v)); | |
| } catch (MalformedURLException e) { | |
| throw new IllegalArgumentException(e); | |
| } | |
| }); |
Comment on lines
60
to
66
| .map((v) -> { | ||
| try { | ||
| return (v instanceof URL) ? (URL) v : new URL(String.valueOf(v)); | ||
| } catch (MalformedURLException e) { | ||
| throw new IllegalArgumentException(e); | ||
| } | ||
| }); |
Collaborator
There was a problem hiding this comment.
minor:
Suggested change
| .map((v) -> { | |
| try { | |
| return (v instanceof URL) ? (URL) v : new URL(String.valueOf(v)); | |
| } catch (MalformedURLException e) { | |
| throw new IllegalArgumentException(e); | |
| } | |
| }); | |
| .map(v -> { | |
| try { | |
| return v instanceof URL ? (URL) v : new URL(String.valueOf(v)); | |
| } catch (MalformedURLException e) { | |
| throw new IllegalArgumentException(e); | |
| } | |
| }); |
| } catch (MalformedURLException e) { | ||
| throw new IllegalArgumentException(e); | ||
| } | ||
| }); |
Collaborator
There was a problem hiding this comment.
does it make sense to move the repeated logic to a new method CapabilityHelpers#toUrl(Object) ?
Contributor
Author
There was a problem hiding this comment.
yes, it does
Comment on lines
39
to
41
| String signingId = cert.getXcodeSigningId() == null | ||
| ? DEFAULT_XCODE_SIGNING_ID | ||
| : cert.getXcodeSigningId(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| String signingId = cert.getXcodeSigningId() == null | |
| ? DEFAULT_XCODE_SIGNING_ID | |
| : cert.getXcodeSigningId(); | |
| String signingId = Optional.ofNullable(cert.getXcodeSigningId()).orElse(DEFAULT_XCODE_SIGNING_ID); |
valfirst
approved these changes
Oct 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Added WDA-related XCUITestOptions
Types of changes