fix: Use lower case for Windows platform key in ElementMap#1421
Merged
SrinivasanTarget merged 1 commit intoappium:masterfrom Dec 22, 2020
Merged
fix: Use lower case for Windows platform key in ElementMap#1421SrinivasanTarget merged 1 commit intoappium:masterfrom
SrinivasanTarget merged 1 commit intoappium:masterfrom
Conversation
mykola-mokhnach
approved these changes
Dec 15, 2020
Contributor
There was a problem hiding this comment.
This should make no difference for Appium, since the comparison is anyway case-insensitive.
Collaborator
Author
|
@mykola-mokhnach I believe the problem comes from these lines where the keys to find are converted to lower case: |
SrinivasanTarget
approved these changes
Dec 15, 2020
95b8411 to
2c8d7df
Compare
This was referenced Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Fixes #965
Fixes #774
Fixes #1247
Types of changes
What types of changes are you proposing/introducing to Java client?