E54B Page factory list element not initialized when parameterized by gener… by JamesSassano · Pull Request #1237 · appium/java-client · GitHub
[go: up one dir, main page]

Skip to content

Page factory list element not initialized when parameterized by gener…#1237

Merged
mykola-mokhnach merged 2 commits intoappium:masterfrom
JamesSassano:master
Sep 16, 2019
Merged

Page factory list element not initialized when parameterized by gener…#1237
mykola-mokhnach merged 2 commits intoappium:masterfrom
JamesSassano:master

Conversation

@JamesSassano
Copy link
Contributor

…ic type (#1150)

Change list

When a page factory field is a list of a generic type, add an an addition check to see if the generic type is bound to one of the "availableElementClasses" (Web, Remote, Mobile, etc Element).

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

#1150

@jsf-clabot
Copy link
jsf-clabot commented Sep 15, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor
@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0