8000 fix: Avoid using getSession call for capability values retrieval by mykola-mokhnach · Pull Request #1216 · appium/java-client · GitHub
[go: up one dir, main page]
Skip to content

fix: Avoid using getSession call for capability values retrieval #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mykola-mokhnach merged 1 commit into from
< 8000 /div> Aug 27, 2019
Merged

fix: Avoid using getSession call for capability values retrieval #1216

mykola-mokhnach merged 1 commit into from
Aug 27, 2019

Conversation

@mykola-mokhnach
Copy link
Contributor
@mykola-mokhnach mykola-mokhnach commented Aug 26, 2019 •
edited
Loading

Change list

W3C protocol does not contain getSession API in its spec, which means all calls to HasSessionDetails interface methods will end up with no such method error. As a result, I have replaced all the "static" calls with simple capabilities extraction and the "dynamic" call uses the fact that none of native mobile drivers support javascript execution, - this only works in browser context.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

See https://github.com/appium/appium/issues/13124#issuecomment-524850823

@mykola-mokhnach mykola-mokhnach changed the title Avoid using getSession call for capability values retrieval fix: Avoid using getSession call for capability values retrieval Aug 26, 2019
@mykola-mokhnach mykola-mokhnach changed the title fix: Avoid using getSession call for capability values retrieval [WIP] fix: Avoid using getSession call for capability values retrieval Aug 26, 2019
@mykola-mokhnach mykola-mokhnach changed the title [WIP] fix: Avoid using getSession call for capability values retrieval fix: Avoid using getSession call for capability values retrieval Aug 27, 2019
< 8000 div data-view-component="true" class="TimelineItem-body">
@mykola-mokhnach
fix: Avoid using getSession call for capability values retrieval
5330470
@mykola-mokhnach
Copy link
Contributor Author
mykola-mokhnach commented Aug 27, 2019 •
edited
Loading

The error in e2e tests is a CI flakiness issue

SrinivasanTarget
SrinivasanTarget approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member
@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SrinivasanTarget
Copy link
Member
SrinivasanTarget commented Aug 27, 2019

The error in e2e tests is a CI flakiness issue

Yeah, I did notice in master. Will fix it asap.

@mykola-mokhnach mykola-mokhnach merged commit 1e80399 into appium:master Aug 27, 2019
@mykola-mokhnach mykola-mokhnach deleted the get_session branch August 27, 2019 11:38
This was referenced Sep 13, 2019
Closed
Closed
@nickdelaneydotio nickdelaneydotio mentioned this pull request Apr 16, 2021
Closed
@valfirst valfirst mentioned this pull request Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

@KazuCocoa KazuCocoa Awaiting requested review from KazuCocoa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mykola-mokhnach @SrinivasanTarget
0