8000 fix: serval incompatible and unfriendly settings by lir2002 · Pull Request #1781 · apitable/apitable · GitHub
[go: up one dir, main page]

Skip to content

fix: serval incompatible and unfriendly settings #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lir2002
Copy link
@lir2002 lir2002 commented Feb 15, 2025

cross-env is added to adapt Windows environment
scripts/export-env.sh is updated to adapt Cygwin in Windows
use native docker volume other than local directory to mount data driver to overcome an incompatbile issue in Windows which leads mysql container always fail
remove version from docker compose yaml which is deprecated by modern docker engine.
adjust Makefile to keep docker volumes when run make down adjust unfriendly IMAGE_PULL_POLICY to avoid always check docker-register which leads failure frequently for developers in China mainland.

Submit a pull request for this project.

Why?

As a developer, especially one work in Windows environment, I see lots of unfriendly behaviors. For examples,

  • Mysql always faills to start, because it mounts a local folder as data driver.
  • Docker pull always check docker register server and for developers in China mainland it could lead frequent failures.
  • Bash scripts are not test for Windows Cygwin and some do not work therefore.
  • Scripts for in package.json are not test for Windows and some do not work therefore.

What?

  • Developers who work in Windows and especially in China Mainland would save large amount of time when setting their local development environment.
  • The change would not impact production environment.

How?

Follow the provided guide for Developer to set up a local development environment in Windows Cygwin.

cross-env is added to suit Windows environment
scripts/export-env.sh is updated to adapt Cywin in Windows
use native docker volume other than local directory to mount data driver to overcome an incompatbile issue in Windows which leads mysql container always fail
remove version from docker compose yaml which is deprecated by modern docker engine.
adjust Makefile to keep docker volumes when run make down
adjust unfriendly IMAGE_PULL_POLICY to avoid always check docker-register which leads failure frequently for developers in China mainland.
@CLAassistant
Copy link
CLAassistant commented Feb 15, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0