[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing expected header value in the error message #57

Merged
merged 2 commits into from
May 25, 2015

Conversation

netmilk
Copy link
Contributor
@netmilk netmilk commented May 25, 2015

No description provided.

@netmilk netmilk force-pushed the netmilk/header-messages-fix branch from 6c9b221 to d01272a Compare May 25, 2015 13:55
module.exports = (message) ->
caseless = require 'caseless'

module.exports = (message, expectedHeaders) ->
if message.indexOf("Missing required property:") > 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should here be > 1? Not > -1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probs yes ;)

@kuba-kubula
Copy link
Member

💯 points for using caseless.

@netmilk
Copy link
Contributor Author
netmilk commented May 25, 2015

🍬

netmilk pushed a commit that referenced this pull request May 25, 2015
Showing expected header value in the error message
@netmilk netmilk merged commit b080072 into master May 25, 2015
@netmilk netmilk deleted the netmilk/header-messages-fix branch May 26, 2015 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants