-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation only content negotiation significant headers for value match #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Headers validated for match of value given in expected are:
- All other headers are validated only for their presence, so values is are validated.
- All dependencies updated to latest
- Better handling primitive types on root level in JSON example validation
- Strings in JSONs on root level were causing exception
- On the root level was validated only typo of array or object
- All JSON primitive types are now always validated on JSON root level
@@ -51,7 +51,7 @@ class JsonSchema | |||
|
|||
if typeof @schema == 'string' | |||
try | |||
@schema = JSON.parse(schema) | |||
@schema = JSON.parse(@schema) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- Strings in JSONs on root level were causing exception - On the root level was validated only typo of array or object - All JSON primitive types are now always validated on JSON root level
Have a look at IANA's list of standard headers |
assert.deepEqual realOutput, expectedOutput | ||
catch error | ||
catch error | ||
callback.fail "Output of code buffer does not equal. Expected output:\n" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing explicit return
kuba-kubula
added a commit
that referenced
this pull request
Mar 12, 2015
Validation only content negotiation significant headers for value match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.