Added a warning for malformed json #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull-request! I'd vote not to append the sentence about |
|
Appending only if either |
|
I changed the error message in the case of a mismatch between |
|
Is this on it's way in? (just got bit by this and it took a while to spot the error) |
netmilk
pushed a commit
that referenced
this pull request
Jun 30, 2014
Added a warning for malformed json
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refs #26. For the majority of us, this error is thrown when we use malformed JSON. The message is really confusing. Maybe we could work something out along these lines: just adding a warning at the end of the error essage.