8000 fix: skip unitialized typed properties by mbrodala · Pull Request #4527 · api-platform/core · GitHub
[go: up one dir, main page]
Skip to content

fix: skip unitialized typed properties #4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: skip unitialized typed properties #4527

wants to merge 1 commit into from

Conversation

mbrodala
Copy link
Contributor
@mbrodala mbrodala commented Oct 27, 2021 •
edited
Loading
Q A
Branch? 2.6
Tickets #3974
License MIT
Doc PR n/a

See symfony/symfony#36117

@mbrodala mbrodala changed the title fix: skip unitialized typed propertes fix: skip unitialized typed properties Oct 27, 2021
@dunglas
Copy link
Member
dunglas commented Oct 28, 2021

This should target the 2.6 branch. Could you also add a test please?

@mbrodala mbrodala changed the base branch from main to 2.6 November 8, 2021 15:37
@mbrodala
Copy link
Contributor Author
mbrodala commented Nov 8, 2021

I've switched to the 2.6 branch now. Also I tried to adjust the existing AbstractItemNormalizer test accordingly.

dunglas
dunglas approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member
@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale
Copy link
stale bot commented Nov 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 4, 2022
@stale
Copy link
stale bot commented Jan 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sorry, something went wrong.

@stale stale bot added the stale label Jan 3, 2023
@stale stale bot closed this Jan 10, 2023
@mbrodala mbrodala deleted the patch-1 branch January 19, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
stale wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbrodala @dunglas
0