8000 Lazy console commands by vyacheslav-startsev · Pull Request #3635 · api-platform/core · GitHub
[go: up one dir, main page]
Skip to content

Lazy console commands #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2020
Merged

Lazy console commands #3635

merged 3 commits into from
Jul 23, 2020

Conversation

vyacheslav-startsev
Copy link
Contributor
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Type improvement

Since Symfony 3.4 console commands can be lazy thanks to a static name property.
This change does not break BC because the BC layer is already in the base command's constructor.

dunglas
dunglas approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member
@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch? Can you just run php-cs-fixer please?

@vyacheslav-startsev
Copy link
Contributor Author

Good catch? Can you just run php-cs-fixer please?

done

@soyuka soyuka merged commit 538416f into api-platform:master Jul 23, 2020
@soyuka
Copy link
Member
soyuka commented Jul 23, 2020

thanks @vyacheslav-startsev

@vyacheslav-startsev vyacheslav-startsev deleted the lazy-commands branch July 23, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanpoulain alanpoulain alanpoulain approved these changes

@dunglas dunglas Awaiting requested review from dunglas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyacheslav-startsev @soyuka @dunglas @alanpoulain
0