8000 Add a default context in concerned normalizers by dunglas · Pull Request #2335 · api-platform/core · GitHub
[go: up one dir, main page]
Skip to content

Add a default context in concerned normalizers #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2018
Merged

Add a default context in concerned normalizers #2335

merged 2 commits into from
Nov 18, 2018

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Nov 16, 2018
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR todo

Introduces a default context for all our normalizers, similarly to the one introduced in Symfony 4.2 (symfony/symfony#28709).
Will allow to also use the new config option (symfony/symfony#28927) with API Platform.

@dunglas dunglas requested a review from soyuka November 16, 2018 16:13
antograssiot
antograssiot reviewed Nov 18, 2018
View reviewed changes
Copy link
Contributor
@antograssiot antograssiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dunglas dunglas merged commit d678481 into api-platform:master Nov 18, 2018
@dunglas dunglas deleted the default_context branch November 18, 2018 12:56
@antograssiot antograssiot mentioned this pull request Dec 18, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antograssiot antograssiot antograssiot left review comments

@teohhanhui teohhanhui teohhanhui approved these changes

@soyuka soyuka Awaiting requested review from soyuka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunglas @teohhanhui @antograssiot
0