8000 Replace the old exception to status config with the new Symfony's YAML extension for PHP constants by meyerbaptiste · Pull Request #1251 · api-platform/core · GitHub
[go: up one dir, main page]
Skip to content

Replace the old exception to status config with the new Symfony's YAML extension for PHP constants #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2017
Merged

Replace the old exception to status config with the new Symfony's YAML extension for PHP constants #1251

merged 1 commit into from
Jul 19, 2017

Conversation

meyerbaptiste
Copy link
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

@meyerbaptiste meyerbaptiste force-pushed the use_symfony_php_constants_yaml_extension branch from c52b84c to 9e8b91c Compare July 17, 2017 15:36
@dunglas
Copy link
Member
dunglas commented Jul 17, 2017

What do you think about not deprecating the previous way (I really don't like the !php... notation). We can still use it internally.

@teohhanhui
Copy link
Contributor

The old way should be deprecated.

And the !php/const is YAML syntax (almost - pending symfony/symfony#22913). Users who don't like YAML syntax can already choose not to use YAML as the configuration file format.

@meyerbaptiste
Copy link
Member Author

I'm agree with @teohhanhui, we should only support the most official way of doing it and not also a kind of "homemade hack".

@meyerbaptiste
Replace the old exception to status config with the new Symfony's YAM…
39172a9 
…L extension for PHP constants
@meyerbaptiste meyerbaptiste force-pushed the use_symfony_php_constants_yaml_extension branch from 9e8b91c to 39172a9 Compare July 18, 2017 08:44
@dunglas dunglas merged commit 9c4a116 into api-platform:master Jul 19, 2017
@dunglas
Copy link
Member
dunglas commented Jul 19, 2017

Let's do this so. Can you update the doc please @meyerbaptiste?

@meyerbaptiste meyerbaptiste deleted the use_symfony_php_constants_yaml_extension branch July 19, 2017 18:09
@meyerbaptiste meyerbaptiste mentioned this pull request Aug 23, 2017
Merged
hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
@dunglas
Merge pull request api-platform#1251 from meyerbaptiste/use_symfony_p…
698e96d 
…hp_constants_yaml_extension

Replace the old exception to status config with the new Symfony's YAML extension for PHP constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
50BE No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meyerbaptiste @dunglas @teohhanhui
0